Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-up of: "displayModel.getCaretRect: return a locationHelper.RectLTRB instance", fixes issue in PuTTY #10244

Merged
merged 2 commits into from
Sep 18, 2019

Conversation

LeonarddeR
Copy link
Collaborator

Link to issue number:

Fixes regressions introduced in #10233

Summary of the issue:

It turns out that when implementing #10233, I used the wrong test case, thereby not actually testing that the changes worked as expected. Therefore, this pr introduces two mistakes:

  1. selff instead of self in a method signature
  2. Passing ctypes instances to RectLTRB instead of the actual integer values.

Description of how this pull request fixes the issue:

Fixes these issues.

Testing performed:

  1. Tested that the caret position is again properly detected and read in putty.
  2. Used displayModel.getCaretRect(api.getFocusObject()) in the python console, getting the caret rectangle of the python console input window using the display model.

Known issues with pull request:

None

Change log entry:

None
Sectio

@michaelDCurran michaelDCurran merged commit 0e4bb4a into nvaccess:master Sep 18, 2019
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Sep 18, 2019
@LeonarddeR LeonarddeR deleted the fixCaret branch September 24, 2019 05:10
@LeonarddeR LeonarddeR added the BabbageWork Pull requests filed on behalf of Babbage B.V. label Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BabbageWork Pull requests filed on behalf of Babbage B.V.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants