Fix-up of: "displayModel.getCaretRect: return a locationHelper.RectLTRB instance", fixes issue in PuTTY #10244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes regressions introduced in #10233
Summary of the issue:
It turns out that when implementing #10233, I used the wrong test case, thereby not actually testing that the changes worked as expected. Therefore, this pr introduces two mistakes:
Description of how this pull request fixes the issue:
Fixes these issues.
Testing performed:
displayModel.getCaretRect(api.getFocusObject())
in the python console, getting the caret rectangle of the python console input window using the display model.Known issues with pull request:
None
Change log entry:
None
Sectio