Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow display to turn off for power saving during say all #11118

Merged
merged 2 commits into from
May 7, 2020

Conversation

LeonarddeR
Copy link
Collaborator

@LeonarddeR LeonarddeR commented May 6, 2020

Link to issue number:

#10643 (comment)

Summary of the issue:

When in say all, the screen is forced to stay on even when there are no screen updates. For non-visual use, this seems unnecessary.
Some users may wish to have their screen turn off for power saving reasons.

Description of how this pull request fixes the issue:

No longer provide the winKernel.ES_DISPLAY_REQUIRED flag to SetThreadExecutionState

Testing performed:

Tested that say all still continues for the original use case in #10643

Known issues with pull request:

If the screen really updates, such as due to cursor movement, this may not make any difference. Therefore difference is only expected when:

  • Say all in browse mode with long paragraphs
  • Braille display gestures when reading with the review cursor.

Change log entry:

Copy link
Contributor

@feerrenrut feerrenrut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LeonarddeR

@feerrenrut feerrenrut changed the title Don't force the display to stay on when in say all Allow display to turn off for power saving during say all May 7, 2020
@feerrenrut feerrenrut merged commit 3c5bc1e into nvaccess:master May 7, 2020
@nvaccessAuto nvaccessAuto added this to the 2020.1 milestone May 7, 2020
LeonarddeR added a commit that referenced this pull request Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants