Update pySerial to 3.5 #12038
Closed
Update pySerial to 3.5 #12038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you considered waiting for #11967 to be merged and then installing pySerial using pip? |
|
Closing in favor of #12075 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Description of this pull request
Updates pySerial to version 3.5 (November 2020). While not strictly necessary as far as I know, this ensures we are on the most recent version for our switch to Python 3.8
Testing strategy:
Should be tested with a serial braille display in production for several days to ensure there are no regressions. I have such a display.
Known issues with pull request:
None
Change log entry:
Code Review Checklist:
This checklist is a reminder of things commonly forgotten in a new PR.
Please do a self-review to check these items.
Reviewers will not approve the PR until these are met.