Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system tests for source copies of NVDA #13322

Merged
merged 3 commits into from
Feb 10, 2022

Conversation

lukaszgo1
Copy link
Contributor

@lukaszgo1 lukaszgo1 commented Feb 9, 2022

Link to issue number:

None - Fixes regression introduced in PR #12075

Summary of the issue:

When executing system tests ensuring that NVDA starts and exits correctly we rely on the status of its process i.e. when the process is running NVDA is supposed to be running. While this works well for installed copies source copies are not started directly rather intermediate .bat file is used to start pythonw in a separate process. As a consequence when trying to retrieve status of an NVDA process during tests we get wrong results (the bat file is never running).

Description of how this pull request fixes the issue:

To avoid relying on the state of the process system tests use the NVDA's message window to determine if NVDA is running or not.

Testing strategy:

System tests passes both locally against a source copy and on AppVeyor against a binary one.

Known issues with pull request:

None known

Change log entries:

None needed.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

…he status of the process rather check the message window.
@lukaszgo1 lukaszgo1 marked this pull request as ready for review February 9, 2022 17:06
@lukaszgo1 lukaszgo1 requested a review from a team as a code owner February 9, 2022 17:06
@lukaszgo1 lukaszgo1 requested a review from seanbudd February 9, 2022 17:06
Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lukaszgo1, looks good to me other than 2 minor changes

tests/system/robot/startupShutdownNVDA.py Outdated Show resolved Hide resolved
tests/system/robot/startupShutdownNVDA.py Outdated Show resolved Hide resolved
lukaszgo1 and others added 2 commits February 10, 2022 00:25
Co-authored-by: Sean Budd <[email protected]>
Co-authored-by: Sean Budd <[email protected]>
@seanbudd seanbudd merged commit bfde594 into nvaccess:master Feb 10, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.1 milestone Feb 10, 2022
@lukaszgo1 lukaszgo1 deleted the systemTestsForSourceCopies branch February 10, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants