Remove remaining support for Windows 7 start after logon #15644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanbudd
reviewed
Oct 18, 2023
See test results for failed build of commit 1c278966fa |
seanbudd
reviewed
Oct 20, 2023
user_docs/en/changes.t2t
Outdated
| @@ -76,6 +76,7 @@ That method receives a ``DriverRegistrar`` object on which the ``addUsbDevices`` | |||
| - ``IoThread.autoDeleteApcReference`` has been removed. (#14924, @LeonarddeR) | |||
| - To support capital pitch changes, synthesizers must now explicitly declare their support for the ``PitchCommand`` in the ``supportedCommands`` attribute on the driver. (#15433, @LeonarddeR) | |||
| - ``speechDictHandler.speechDictVars`` has been removed. Use ``NVDAState.WritePaths.speechDictsDir`` instead of ``speechDictHandler.speechDictVars.speechDictsPath``. (#15614, @lukaszgo1) | |||
| - ``easeOfAccess.canConfigTerminateOnDesktopSwitch`` has been removed, as it became obsolete since Windows 7 is no longer supported. (#15644, @LeonarddeR) | |||
There was a problem hiding this comment.
This should be moved to the deprecations list
Suggested change
| - ``easeOfAccess.canConfigTerminateOnDesktopSwitch`` has been removed, as it became obsolete since Windows 7 is no longer supported. (#15644, @LeonarddeR) | |
| - ``easeOfAccess.canConfigTerminateOnDesktopSwitch`` has been deprecated, as it became obsolete since Windows 7 is no longer supported. (#15644, @LeonarddeR) |
seanbudd
approved these changes
Oct 22, 2023
This was referenced Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15662
Follow up of #15544
Summary of the issue:
In #15544, support for the ease of access proxy for Windows 7 was removed, but there was still some remaining code for Windows 7 to set start after logon using a run key.
Description of user facing changes
None.
Description of development approach
Remove windows 7 support.
Testing strategy:
Manual testing, possibly with a try build. Note that this is only a matter of removing existing code, behavior shouldn't change.
Known issues with pull request:
None known
Code Review Checklist: