Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support aria-braille-input to allow web authors to accept unicode braille input #8340

Closed
wants to merge 1 commit into from

Conversation

michaelDCurran
Copy link
Member

@michaelDCurran michaelDCurran commented May 29, 2018

Link to issue number:

None.

Summary of the issue:

Web authors have asked for a way to have their controls accept raw braille input. An example where this would be useful would be an online math editor that could allow the user to directly type in Nemeth braille input on a Braille display.

Description of how this pull request fixes the issue:

A new aria-braille-input attribute is going to be proposed to the ARIA working group for consideration (see w3c/aria#771). NVDA looks for this property in all web browsers, and maps it to a new requiresUnicodeBrailleInput property on NVDAObjects.
If this property is true on the control with focus, then NVDA will automatically use the unicode braille table for braille input rather than the currently configured input braille table.

Testing performed:

Testcase: https://sinabahram.github.io/aria-playground/BrailleInput.html
The first control takes normal text, the second control takes braille input (as aria-braille-input has a value of "true").
Tested in Firefox and Internet Explorer.

Known issues with pull request:

Although NVDA supports this property in IA2, MSHTML and UIA, it does not currently work in Edge or Chrome due to these browsers not exposing unknown ARIA properties.

Change log entry:

…raw unicode braille dots from a braille display, by specifying aria-brailleInput="true".

Although support for all browsers has been added to NVDA, this does not yet work in Edge/Chrome as those browsers do not currently let through unknown ARIA properties.
@michaelDCurran michaelDCurran requested a review from feerrenrut May 29, 2018 06:06
@josephsl
Copy link
Collaborator

josephsl commented May 29, 2018 via email

@LeonarddeR
Copy link
Collaborator

Is there a particular reason why you did not yet map this to a state, or even a different role?

@michaelDCurran
Copy link
Member Author

michaelDCurran commented May 29, 2018 via email

@jcsteh
Copy link
Contributor

jcsteh commented Jun 8, 2018

At the end of the day, this is still essentially a text box, so I'd suggest a new role isn't appropriate. This is more like HTML <input type="email">, which is a text input specific to email addresses. We're just saying this is a text input specific to Unicode braille. Thus, I've proposed aria-text-input-type="braille".

@feerrenrut
Copy link
Contributor

I think we might need to be careful here, at the most basic level we are talking about getting raw, untranslated braille input from the screenreader. This may be to a text input field or some other element receiving the input. At a low level its about disabling translation of the dots that are input by the user, and says nothing about how this may be displayed to the user in the web page.

@jcsteh
Copy link
Contributor

jcsteh commented Jun 8, 2018 via email

@feerrenrut
Copy link
Contributor

I'm worried about conflating the semantic information for the final value e.g. "email" with the method used to convey it e.g. "braille". What about handwriting, speech, or sign?

@jcsteh
Copy link
Contributor

jcsteh commented Jun 8, 2018 via email

@feerrenrut
Copy link
Contributor

I still think aria-input-type="braille" might allow for less future attribute clutter than aria-braille-input="true".

Absolutely with you on that one.

@michaelDCurran
Copy link
Member Author

michaelDCurran commented Feb 3, 2019 via email

@LeonarddeR
Copy link
Collaborator

@michaelDCurran Is this still expected to be used at some point?

@michaelDCurran
Copy link
Member Author

Again, we will only do something about this if it becomes an ARIA standard. This was a proof of concept.

@LeonarddeR
Copy link
Collaborator

Coming across this again, given how we handled pr's like this recently, wouldn't it be better to close this and revisit it when this is ever needed again? Or, at least, make it a draft given the proof of concept state of the work?

@michaelDCurran michaelDCurran marked this pull request as draft October 12, 2020 01:43
@michaelDCurran
Copy link
Member Author

@LeonarddeR I agree. It is now a draft.

@pkra
Copy link

pkra commented Nov 12, 2020

I'm trying to revive this idea on the ARIA end (hoping we can still get this into ARIA 1.3) and I've extracted part of this thread at w3c/aria#771 (comment). If you could add or correct what I wrote over there, it would be most helpful!

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Jul 2, 2024
@SaschaCowley
Copy link
Member

SaschaCowley commented Jul 2, 2024

ARIA support has now been pushed back to ARIA 1.4 and deprioritised.

@seanbudd
Copy link
Member

seanbudd commented Jul 2, 2024

I suggest we replace this PR with an issue, and block it until a spec is decided upon

@seanbudd
Copy link
Member

seanbudd commented Jul 3, 2024

@coderabbitai can you open an issue to document the discussion on this PR, i.e. "supporting aria-braille-input to allow web authors to accept unicode braille input". Ensure it is noted that it is blocked on w3c/aria#771

Please use our feature request issue template

Copy link
Contributor

coderabbitai bot commented Jul 3, 2024

@seanbudd, I have created the issue as requested. You can find it at the following link: #16801.

Analysis chain

@seanbudd, I have created an issue to document the discussion on this PR, noting that it is blocked on w3c/aria#771. The issue has been created using the feature request issue template.

Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
gh issue create --title "Supporting aria-braille-input to allow web authors to accept Unicode braille input" --body "
## Summary
This issue documents the discussion from [PR #8340](https://github.com/nvaccess/nvda/pull/8340) regarding supporting aria-braille-input to allow web authors to accept Unicode braille input. The feature is intended to enable web authors to have their controls accept raw braille input, such as for an online math editor allowing direct Nemeth braille input on a Braille display.

## Detailed Description
### Discussion Summary:
- Web authors requested a way to accept raw braille input.
- NVDA looks for the aria-braille-input property in web browsers and maps it to a new requiresUnicodeBrailleInput property on NVDAObjects.
- If this property is true on the control with focus, NVDA will use the Unicode braille table for braille input instead of the currently configured input braille table.

### Comments and Considerations:
- There was a discussion about whether to map this to a state or a different role.
- The ARIA working group may suggest using a role rather than a property.
- Concerns were raised about conflating the semantic information for the final value with the method used to convey it.

### Current Status:
- This was a proof of concept.
- ARIA support has been pushed back to ARIA 1.4 and deprioritized.
- The PR will be replaced with this issue and blocked until a spec is decided upon.

### Blocked By:
This issue is blocked on [w3c/aria#771](https://github.com/w3c/aria/issues/771).

## Feature Request Issue Template
- Description: Supporting aria-braille-input to allow web authors to accept Unicode braille input.
- Justification: To enable web authors to accept raw braille input for specific use cases like online math editors.

" --assignee "seanbudd"

Length of output: 1855

Actions performed

Comments resolved.

@seanbudd seanbudd closed this Jul 3, 2024
@seanbudd seanbudd added blocked/needs-external-fix Abandoned requested reports or updates are missing since more than 1 year, author or users are not available. labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Abandoned requested reports or updates are missing since more than 1 year, author or users are not available. ARIA blocked/needs-external-fix blocked component/braille conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants