Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
This pr depends on the following child pull requests.
Summary of the issue:
NVDA includes git submodules from several sources. In the current situation, the py2exe packages is bundled inside the nvda-misc-deps repository. It was discussed with @feerrenrut an decided that we wanted to store all our binary dependencies in separate repositories.
A short discussion about virtual environments
When preparing this work, we also discussed the use of virtual environments for the build process. Thereby, I especially zoomed in on the pipenv project. Pipenv would allow us to give a very simple overview of external dependencies needed for the project, fetch them on demand from PyPI, etc. However, it was decided not to build on pipenv for this:
pip install pipenv
andppienv --python 3 -d install
before they could get started.having said that, we encourage users to embrace the concept of virtual environments. The python documentation of venv is helpful to get to know more about this.
Description of how this pull request fixes the issue:
This pr also logs the version of six to the NVDA log when logging information about the current version of wx python.
Testing performed:
Tested using @josephsl's py3000 branch, cherrypicking the commit from this pr. Also made sure that py2exe imported correctly from the python console. NO attempts have yet been made to build NVDA with py2exe from this repository, see #9605
Known issues with pull request:
Change log entry: