-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address RMMAllocator error for UCX Endoscopy Tool Tracking application #604
Address RMMAllocator error for UCX Endoscopy Tool Tracking application #604
Conversation
@mocsharp could you please provide more details on the error and root cause? Are the RMMAllocator crash and benchmarking option related? |
Updated description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question on defaults, code looks good otherwise. Will wait for approval from @grlee77 to merge.
applications/distributed/ucx/ucx_endoscopy_tool_tracking/cpp/endoscopy_tool_tracking.yaml
Outdated
Show resolved
Hide resolved
ping @grlee77 for review |
@grlee77 can you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The change looks good to me. I will add an additional description motivating why it may be necessary.
@mocsharp, please either update the default value of benchmarking to false
in the YAML or change the comment describing the default to be consistent. I will go ahead and approve, so you can merge after that without requesting another review
applications/distributed/ucx/ucx_endoscopy_tool_tracking/cpp/endoscopy_tool_tracking.yaml
Outdated
Show resolved
Hide resolved
@tbirdso: In practice there can be some degree of "parallel" operation of operators even with the
I think v2.6 had some changes to |
70e91f7
to
4ca32c7
Compare
…me=false Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
4ca32c7
to
dc7ded8
Compare
Thanks all, looks good! |
This PR addresses a
RMMAllocator
crash when running the application withrealtime
set tofalse
(play the video as fast as possible).As @grlee77 suggested, the fix is to explicitly set the RMM Allocator's initial and maximum sizes.
Adds the ability to enable/disable data flow benchmarking through configuration.