Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround after dependencies have been fixed #649

Merged
merged 6 commits into from
Jan 23, 2025

Conversation

MMelQin
Copy link
Contributor

@MMelQin MMelQin commented Dec 22, 2024

This PR remove workarounds that had to be used in the earlier merged versions.

  • Two requirements files were needed, with the first one install holoscan since it pins its dependencies, and the second with all other dependencies to avoid version conflicts of a couple module (without functionality issue). Holoscan has since removed/relaxed pinning, so a single requirements file works
  • Single Dockerfile supporting both x86_64 and aarch64 builds. Python Wheel for Torch on aarch64 and CUDA 12.6 was not available, and around 12/18/2024 the nightly build Wheel started appearing. As of now, RC test version is also availabe, so the pull request had been updated to make use of this RC build while waiting for the released version in early Jan 2025.

The release date of Torch 2.6 CUDA 12.6 is now set at 01/29/2025. This app will be updated later to use that version, and for now, OK to be reviewed and merged.

Screenshot of running the app on IGX DevKit 1.0GA is attached.
HoloHubApp-Screenshot_2025-01-22

@jjomier
Copy link
Contributor

jjomier commented Jan 21, 2025

@MMelQin is this ready to merge after review?

@MMelQin
Copy link
Contributor Author

MMelQin commented Jan 21, 2025

@MMelQin is this ready to merge after review?

I am adding more changes and testing on IGX dev kit. Plan to have it reviewed later this week. Was giving the other SDK a bit of TLC last week.

@MMelQin MMelQin force-pushed the mq/remove_workarounds branch from 4cea208 to 44aaf5a Compare January 22, 2025 19:45
@MMelQin MMelQin changed the title [WIP] Remove workaround after dependencies have been fixed Remove workaround after dependencies have been fixed Jan 22, 2025
@MMelQin MMelQin requested review from jjomier and tbirdso January 22, 2025 22:21
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbirdso tbirdso merged commit db97348 into main Jan 23, 2025
6 checks passed
@tbirdso tbirdso deleted the mq/remove_workarounds branch January 23, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants