Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix curl url reuse #602

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Fix curl url reuse #602

merged 2 commits into from
Feb 11, 2025

Conversation

juntuu
Copy link
Contributor

@juntuu juntuu commented Jul 9, 2024

Fixes #601

@juntuu @Conni2461
Fix typo
3054ca2
@juntuu @Conni2461
fix(curl): Do not reuse URL from previous call
3d3b823 
Previously the URL could be accidentally reused between requests.

    local curl = require "plenary.curl"
    curl.get("url", { dry_run = true }) -- { ..., "-X", "GET", "url" }
    curl.get({ dry_run = true })        -- { ..., "-X", "GET", "url" }
@Conni2461
Copy link
Collaborator

thanks :)

@Conni2461 Conni2461 merged commit f031bef into nvim-lua:master Feb 11, 2025
6 of 7 checks passed
@juntuu juntuu deleted the fix-curl-url-reuse branch February 13, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Curl module may accidentally reuse URL
2 participants
@juntuu @Conni2461