Correcting some behavior in Path:find_upwards #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you want me to revert the return value change, I can - it was just causing me a bit of grief expecting a nil value on failure to finally realize it was a string for some reason. |
now calls Path:root properly, and return nil at the end of execution instead of emptystring
|
thanks :) i rebased the branch, to fixup ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_upwardsfails on Windows systems, as it passes the incorrect argument type topath.root.Additionally,
find_upwardscurrently returns an empty string""if no result is found.This is incompatible with
find_upwardsreturning aPathinstance when a result is found.