Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rocks sync command #385

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: rocks sync command #385

wants to merge 1 commit into from

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented Feb 2, 2025 •
edited
Loading

Closes #273.

Bonus:

  • Fixes the HasIntegrity implementation for PathBuf.
  • Removes the .git directory when checking out a repo with libgit2, to make sure the hash is reproducible.
    I don't know if this is compatible with nix, but I don't know a better way to solve this right now.
  • Rewires rocks build to use Sync if a lockfile is present, otherwise Install, passing in the project reference.

@mrcjkb mrcjkb marked this pull request as draft February 2, 2025 20:56
@mrcjkb mrcjkb force-pushed the mj/push-svmvwwswpzrv branch 5 times, most recently from 0a66373 to 8d62c67 Compare February 3, 2025 22:41
@mrcjkb mrcjkb marked this pull request as ready for review February 3, 2025 22:41
@mrcjkb mrcjkb force-pushed the mj/push-svmvwwswpzrv branch from 8d62c67 to 791e922 Compare February 3, 2025 22:55
@mrcjkb mrcjkb marked this pull request as draft February 3, 2025 23:39
@mrcjkb
Copy link
Member Author

mrcjkb commented Feb 3, 2025 •
edited
Loading

issue:

  • rocks build needs to sync the dependencies in rocks.toml before syncing the lockfile, in case dependencies were added or removed manually.

@mrcjkb mrcjkb force-pushed the mj/push-svmvwwswpzrv branch 2 times, most recently from b1b091f to cdff4c7 Compare February 4, 2025 19:59
@mrcjkb mrcjkb marked this pull request as ready for review February 4, 2025 20:01
@mrcjkb mrcjkb force-pushed the mj/push-svmvwwswpzrv branch 3 times, most recently from 5ea8d07 to 53fd75c Compare February 4, 2025 20:19
@mrcjkb mrcjkb force-pushed the mj/push-svmvwwswpzrv branch from 53fd75c to 92f0163 Compare February 4, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NTBBloodbath NTBBloodbath Awaiting requested review from NTBBloodbath NTBBloodbath is a code owner

@vhyrro vhyrro Awaiting requested review from vhyrro vhyrro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] rocks sync command
1 participant
@mrcjkb