Run viewer asynchronously using vim.system
#873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when the viewer opened, the editor was blocked until the user closes the viewer. Now, the viewer opens asynchronously (using `vim.system` rather than the old `vim.fn.system`); in this way, the user can view the PDF while continuing editing the org file in the editor.
|
I understand also that the next step might be to add support for detecting PDFs that are already open in a PDF viewer and not opening them after export (and just updating them). But I guess this is going to be difficult to maintain and is not the main functionality of this plugin as one might expect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the viewer opened, the editor was blocked until the user closes the viewer. Now, the viewer opens asynchronously (using
vim.systemrather than the oldvim.fn.system); in this way, the user can view the PDF while continuing editing the org file in the editor.