Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the moon is not a planet #2072

Closed
wants to merge 1 commit into from

Conversation

axieax
Copy link

@axieax axieax commented Jul 13, 2022

Description

Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context

My inner astrologer just realised the moon is in :Telescope planets, but it ain't a planet :((

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Very important bug fix (hopefully doesn't break things)!!

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration

The moon is not one of the planets in this credible source. Also Google says it ain't so it ain't. Please see the images below.

image

image

Configuration:

  • Neovim version (nvim --version): nvim v0.7.2
  • Operating system and version: arch btw

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (lua annotations)

@razin99
Copy link

razin99 commented Jul 13, 2022

Great research on this issue, I agree this should be the case. Moon is a satellite.

@stevenp2
Copy link
Contributor

perhaps it would have been better if you didn't completely remove the moon file, but treat it as an easter egg like pluto

@Conni2461
Copy link
Member

I like @stevenp2 proposal more. Lets hide it behind a show_moon option

@Conni2461
Copy link
Member

resolved by b5833a6

Thanks for bringing up this bug :)

@Conni2461 Conni2461 closed this Jul 22, 2022
Conni2461 pushed a commit that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants