fix(tests): uses testharness in scrolling strategy #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamtajti
commented
Jan 6, 2023
| @@ -107,12 +111,12 @@ describe("builtin.find_files", function() | |||
|
|
|||
| it("should be able to c-n the items", function() | |||
| tester.run_string [[ | |||
| runner.picker('find_files', 'fixtures/file<c-n>', { | |||
| runner.picker('find_files', 'fixtures/find_files/file<c-n>', { | |||
There was a problem hiding this comment.
I have included added a subdirectory alongside of fixing this test to prepare for other fixtures in my next PR.
4 tasks
kkharji
approved these changes
Jan 6, 2023
|
Thanks for fixing that test and the ci pipeline :) |
Conni2461
pushed a commit
that referenced
this pull request
Jan 7, 2023
(cherry picked from commit cd67e81)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that the find-files scrolling strategies tend to timeout while fixing another issue. We agreed to create a separate pull request where we update this test to use testharness.
Type of change
How Has This Been Tested?
make testConfiguration:
Checklist: