feat: utilize last window cursor position #2416
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2386
Description
When using pickers to open buffers, fallback on window's last cursor position for that buffer.
This preserves the cursor location (row and col) for previously opened buffers.
This only impacts the column location for the
buffers
picker. But currently also impact the line number as well forfind_files
. This last point might be too disruptive even though I believe the change is for the better. I can modify the PR to revert this however.Fixes # (issue)
#2386
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration
:vnew
:Telescope buffers
and open the buffer from above -> cursor should be in the same location between the two windows (previously would always go to the 1st column):vnew
:Telescope find_files
and open the buffer from above -> cursor should be in the same location between the windows (previously would always go to [1,1]) -> this behavior MAY be consider too drastic:Telescope live_grep
and grep for some random word in that buffer not under the cursor of that bufferConfiguration:
Linux archlinux 6.1.12-arch1-1 #1 SMP PREEMPT_DYNAMIC Tue, 14 Feb 2023 22:08:08 +0000 x86_64 GNU/Linux
Checklist: