fix: expr for insert mode #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
quite sure vim.keymap was added in 0.7 |
|
Random drive by comment (as I was just reading through this issue) but you might benefit from |
Conni2461
force-pushed
the
fix/expr_insert
branch
from
e589e2d to
0c73abd
Compare
Conni2461
added a commit
that referenced
this pull request
Jun 9, 2023
(cherry picked from commit 9e3922f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2431
it only contains the fix for 2431, it does not completely refactor mappings. plan to do that in a separate branch. I also cant recall when
vim.keymapwas introduced and if it would break 0.7 support (we still have on 0.1.x). need to figure this out before merging ^^