Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use :botright modifier for quickfix window open #2554

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

MunifTanjim
Copy link
Contributor

@MunifTanjim MunifTanjim commented Jun 7, 2023

Description

Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context

Fixes #2142

Aligns the behavior with vim.diagnostic.setqflist. Vim's default behavior with :copen is kinda buggy. It opens the window below the last window in the layout (i.e. at the bottom right corner). Created an issue about that vim/vim#12501.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration

  • Open two split (left and right)
  • Open the quickfix window from telescope using <C-q>
  • It should open at the bottom (instead of bottom right corner)

Configuration:

  • Neovim version (nvim --version):
  • Operating system and version:

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (lua annotations)

Copy link
Contributor

@jamestrew jamestrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@jamestrew jamestrew merged commit 9a82b5b into nvim-telescope:master Jun 7, 2023
Conni2461 pushed a commit that referenced this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow actions.open_qflist to utilize split modifiers like :botright, :rightbelow, etc
2 participants