feat(lsp): added support for dynamic capabilities #2594
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for dynamic registration of capabilities to all the lsp pickers.
I also refactored the relevant code a bit to make it less verbose.
Any code that wants to check lsp capabilities should use
client.supports_method
.That function includes checks for dynamically registered capabilities.
Just checking
server_capabilities
only includes caps that were advertised during init.Fixes LazyVim/LazyVim#990
Fixes
goto definition
for a number of lsp servers likejdtls
andsolargraph
Type of change
How Has This Been Tested?
I've testes all the methods using several LSP servers including the one
solargraph
where go to definition was broken.Checklist: