fix(telescope.state.get_existing_prompts): it should only return keys that are numbers #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good. maybe we can rename the function |
…e impl more efficient
|
I did the name change and also used pairs to only iterate once over the table since tbl_keys and tbl_filter each use a pairs internally and that is slower |
jamestrew
approved these changes
Sep 4, 2023
rameshsanth
pushed a commit
to rameshsanth/telescope.nvim
that referenced
this pull request
Nov 17, 2023
… that are numbers (nvim-telescope#2684) * fix(telescope.state.get_existing_prompts): it should only return keys that are numbers * Table keys not table values should be numbers * Rename get_existing_prompts to get_existing_prompt_bufnrs and make the impl more efficient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
telescope.state.get_existing_prompts currently returns all the keys from TelescopeGlobalState, this includes the 'global' key. This function is only used in Picker:close_existing_pickers where we iterate through the prompt_bufnr and call actions.close on each prompt_bufnr so it should only return keys that are numbers
Type of change
How Has This Been Tested?
Run
:lua =require('telescope.state').get_existing_prompts()
When there are no pickers opened. It should return and empty table. With a picker present it should return the bufnr for that picker's prompt.
Checklist: