fix(internal.resume): dynamic_preview_title was not respected and title became static #2696
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Picker:new there was
so if a preview_title was not provided at creation it became static forever. This is a problem when you resume a picker as internal.resume calls Picker:new again and the same preview_title is populated during runtime by the dynamic_preview_title. So now that field is not nil and will become static forever.
To fix it add an additional check. If the picker is resumed and fix_preview_title is not already set by the first creation do not set it now.
This fixes #2689
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Manual testing. Set dynamic_preview_title = true in defaults when you setup Telescope and then open the find_files picker close it and resume.
Checklist: