-
-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Windows: allow binary without extension #3093
🐛 Windows: allow binary without extension #3093
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's kinda weird that we need to check for vim.fn.executable("rg.exe")
even when rg
is installed.
Sorry, I deleted the branch by mistake. I've reopened the PR. |
Co-authored-by: James Trew <[email protected]>
Thank you for review!
I believe I wrote it to check for |
yes, I think this is ok. |
thanks! |
* 🐛 Windows: allow binary without extension * show `(unknown version)` if parse failed Co-authored-by: James Trew <[email protected]> --------- Co-authored-by: ras0q <[email protected]> Co-authored-by: James Trew <[email protected]> (cherry picked from commit 29fddf7)
Description
In Windows, if only
rg
without extension is installed andrg.exe
is not for some reason, checkhealth had failed previously.This PR allows binaries without extensions to be recognised in Windows.
FIXME: In Windows environment,
io.popen(binary .. " --version")
does not return any outputs. How can I fix it?Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration
Configuration:
Checklist: