Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no longer leaking one buffer previewer in some occasions #664

Merged
merged 9 commits into from
Mar 30, 2021

Conversation

Conni2461
Copy link
Member

@Conni2461 Conni2461 commented Mar 17, 2021

And some other small things i noticed in the past week:

@Conni2461
Copy link
Member Author

Docgen CI deleted everything because tree-sitter-lua wasn't bumped yet :| https://github.com/Conni2461/telescope.nvim/runs/2133421164?check_suite_focus=true

@rockerBOO
Copy link
Member

I believe this is due to neovim needing to be built with treesitter 19.x. They just released an update for nvim-treesitter. I dont think tree-sitter-lua needs to be bumped in this case. Not sure the environment that is building the nightly.

nvim-treesitter/nvim-treesitter#1000

@Conni2461
Copy link
Member Author

The last nightly was build with 0.19.x so only ABI 13 is valid. docgen and the used grammar for docgen tree-sitter-lua is still build with 0.18.x. TJ does the bump to 0.19.x here: tjdevries/tree-sitter-lua#15

This is unrelated to nvim-treesitter because nvim-treesitter ships a different grammar.

@Conni2461
Copy link
Member Author

Okay lot of fixes here :) Its done so someone should take a quick look at it and after that can merge it.

Docgen also works again 🎉

CC @elianiva

lua/telescope/pickers.lua Outdated Show resolved Hide resolved
@elianiva
Copy link
Member

except the two comments I left, looks good to me. GJ!

@Conni2461 Conni2461 merged commit aefc831 into nvim-telescope:master Mar 30, 2021
@Conni2461 Conni2461 deleted the fix_leaking branch March 30, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants