-
-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add git_stash picker #800
feat: add git_stash picker #800
Conversation
@amirrezaask I will take a further look into this PR in the coming days with an actual review, but for now can you fix the luacheck linting issues please? 🙂 Ignore the tests failing atm, that is to do with #821. |
lua/telescope/actions/init.lua
Outdated
--- Applies an existing git stash | ||
---@param prompt_bufnr number: The prompt bufnr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure github actions for your fork are enabled so docgen is running. We are also running into a maximum amount of docs we can generate for that file (some bug in treesitter) so we are currently documenting new functions like this:
-- TODO: add this function header back once the treesitter max-query bug is resolved
--
--
With two rather than 3 -
. See 379
Can we get a mention of this picker in the README? |
Thanks :) Looks almost good to me. And can you address #800 (comment), because even if your PR isn't running docgen (because not enabled or github actions don't want to) another PR will and we will run into issues. :) Thanks |
lua/telescope/make_entry.lua
Outdated
return { | ||
value = splitted[1], | ||
ordinal = splitted[2], | ||
msg = splitted[2], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we even need the msg entry somewhere? Otherwise we can just remove that tbl entry, can't we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove msg entry also show git stash message in results.
…nvim into git_stash_picker
skip-checks: true
Apparently we could generate one more functions, so i miscounted 🤣 Thanks :) LGTM |
PR #800 add git_stash picker. However, it's not added as a field in builtin.
Adds git_stash picker
Resolves #799