Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add git_stash picker #800

Merged
merged 10 commits into from
May 11, 2021

Conversation

amirrezaask
Copy link
Contributor

@amirrezaask amirrezaask commented Apr 27, 2021

Adds git_stash picker

Resolves #799

@amirrezaask amirrezaask mentioned this pull request Apr 27, 2021
@amirrezaask amirrezaask changed the title WIP: add git_stash picker feat: add git_stash picker Apr 29, 2021
@amirrezaask amirrezaask reopened this Apr 29, 2021
@smithbm2316
Copy link
Contributor

@amirrezaask I will take a further look into this PR in the coming days with an actual review, but for now can you fix the luacheck linting issues please? 🙂 Ignore the tests failing atm, that is to do with #821.

Comment on lines 343 to 344
--- Applies an existing git stash
---@param prompt_bufnr number: The prompt bufnr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure github actions for your fork are enabled so docgen is running. We are also running into a maximum amount of docs we can generate for that file (some bug in treesitter) so we are currently documenting new functions like this:

-- TODO: add this function header back once the treesitter max-query bug is resolved
--
--

With two rather than 3 -. See 379

@Conni2461
Copy link
Member

Can we get a mention of this picker in the README?

@Conni2461
Copy link
Member

Thanks :) Looks almost good to me.
Can you add the picker to the Git Pickers table in the readme? (you might need to rebase because another pr also edited the readme today)

And can you address #800 (comment), because even if your PR isn't running docgen (because not enabled or github actions don't want to) another PR will and we will run into issues. :)

Thanks

return {
value = splitted[1],
ordinal = splitted[2],
msg = splitted[2],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need the msg entry somewhere? Otherwise we can just remove that tbl entry, can't we?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove msg entry also show git stash message in results.

@Conni2461
Copy link
Member

Apparently we could generate one more functions, so i miscounted 🤣

Thanks :) LGTM

@Conni2461 Conni2461 merged commit 9fd242d into nvim-telescope:master May 11, 2021
Conni2461 pushed a commit that referenced this pull request May 11, 2021
PR #800 add git_stash picker. However, it's not added as a field in builtin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git stash picker
3 participants