Jumplist picker uses quickfix entry maker. Delete jumplist entry maker. #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conni2461
reviewed
Jul 10, 2021
Conni2461
reviewed
Jul 11, 2021
| table.insert(sorted_jumplist, jumplist[i]) | ||
| if vim.api.nvim_buf_is_valid(jumplist[i].bufnr) then | ||
| jumplist[i].text = vim.api.nvim_buf_get_lines(jumplist[i].bufnr, jumplist[i].lnum, jumplist[i].lnum+1, | ||
| false)[1] or '' |
There was a problem hiding this comment.
I think this or just doesnt do anything. doesnt matter tho 😆
There was a problem hiding this comment.
It does something in my testing. If I bdelete a buffer, than the buffer is still valid, but we can't get the lines for it. Only when I bwipeout a buffer does a buffer become invalid. I'm not 100% on the behavior of buffers in vim and neovim, but I think bdelete keeps a lot of the buffer data around, but unloads the file text from memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I authored #839, I didn't include the jumplist text because we wouldn't be able to get text for closed buffers. This is a non-issue because I've found in my workflow that that recent entries on the jumplist are always open in a buffer. I think that having the buffer text feels a little better when going through the jumplist picker. For entries that aren't open in a buffer, we include empty text, but we expect it to not be surfaced to the user very often.
Another benefit is that the jumplist picker now reuses the quickfix entry maker, as many other pickers already do. This means we can delete the jumplist entry maker.
This is all opinionated. Open to ideas.