feat: add audio file icons, remove audio/video from vim filetypes

[pauchiner]

Closes #404

Roadmap:

• .aac (Advanced Audio Coding)
• .aiff or .aif (Audio Interchange File Format)
• .ape (Monkey's Audio)
• .flac (Free Lossless Audio Codec)
• .mp3 (MPEG-1 Audio Layer)
• .m4a (MPEG-4 Audio)
• .opus (Opus Audio File)
• .ogg (Ogg Vorbis)
• .wav (Waveform Audio File Format)
• .wma (Windows Media Audio)

[alex-courtis]

Looking good; let's add the rest #404 (comment)

[alex-courtis]

These are looking good, however they should actually be in the icons_by_file_extension table.

There are already some of these extensions in there... including mp3.

I'll be grateful if you could move the new ones in there, overwriting.

However... the existing ones are using nf-fa-music. We'll need to use that one, to avoid a breaking change.

[pauchiner]

Sorry, I made those commits in a few free minutes yesterday, I didn't notice either the extensions table or the breaking changes, I'm already working on fixing it.

[alex-courtis]

Looking good: :NvimWebDeviconsHiTest

However I think we might be backwards here: all the new icons are in icons_by_filename wheras they should be in icons_by_file_extension. The user will be finding music file icons via get_icon with an extension rather than matching an exact file name.

The filetypes will still correctly map to icons_by_file_extension.

[alex-courtis]

Any updates @pauchiner ? This is really close...

[pauchiner]

Sorry, I was absent due to personal things, as soon as I can I will make a commit with the changes.

[alex-courtis]

Looking good, a couple of tidies needed.

[alex-courtis]

The above aren't vim filetypes so should not be mapped to extensions.

[alex-courtis]

Still not quite there...

None of these file types correspond to vim syntax &ft, see /usr/share/nvim/runtime/syntax

We need to remove them from the mapping

-- Map of filetypes -> icon names
local filetypes = {

[pauchiner]

So if aren't vim filetypes, how are mapped?
I think im not understanding your point, Sorry.

[alex-courtis]

So if aren't vim filetypes, how are mapped? I think im not understanding your point, Sorry.

No worries; this is not very clear from the names.

Files like these are simply mapped by their extension against the keys of icons_by_file_extension. There's no need for any extra mapping.

Try

:lua print(require("nvim-web-devicons").get_icon("aiff"))

[hasecilu]

I'm not really sure if PCM file extension is really used, so could be added.

[pauchiner]

I have already deleted the filetypes that I added at the time, but then by the same logic, those that were previously there should also be deleted, such as mp3, mp4, wav...

[alex-courtis]

I have already deleted the filetypes that I added at the time, but then by the same logic, those that were previously there should also be deleted, such as mp3, mp4, wav...

Good catch! Yes, they should be removed.

In the interest of speed, I'll push that change to this branch.

[alex-courtis]

I'm not really sure if PCM file extension is really used, so could be added.

Sounds good! Any others you think of please do raise a PR...

[alex-courtis]

Many thanks for your contribution and many thanks for bearing with all the back and forth.