Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metropolitan France should receive FR ISO code (like Norway) #12

Closed
nvkelso opened this issue Dec 15, 2012 · 4 comments
Closed

Metropolitan France should receive FR ISO code (like Norway) #12

nvkelso opened this issue Dec 15, 2012 · 4 comments
Labels

Comments

@nvkelso
Copy link
Owner

nvkelso commented Dec 15, 2012

No description provided.

@nvkelso
Copy link
Owner Author

nvkelso commented Dec 16, 2012

Should Spratly Island receive PI?

Should United Nations Neutral Zone (UNDOF) receive XD?

Should Syria map unit receive SY?

@nvkelso
Copy link
Owner Author

nvkelso commented Jul 30, 2017

This was completed in 3.x series.

@nvkelso nvkelso closed this as completed Jul 30, 2017
@nvkelso nvkelso removed this from the v4.0.0 milestone Jul 30, 2017
@woodpeck
Copy link

I downloaded ne_10m_admin_0_countries.zip today (v4.0.0) and it (still) lists -99 in the ISO_A2 column for France and Norway. I don't know if this is technically correct on some complex level and feel free to discard this report if it is intentional, but I'm pretty sure I'm not the only user for whom this comes as a surprise. The above discussion sounds like you thought abut the issue but it's not really clear to me if the outcome of the discussion was "yep, France doesn't technically have an ISO_A2 so -99 is correct", or if the outcome was "this should be fixed" (and isn't).

@nvkelso
Copy link
Owner Author

nvkelso commented Nov 13, 2017

Hi Frederick. Yes, there is a technical difference of interpretation over what's what with ISO codes and how the "admin-0" units of the world are organized between ISO and Natural Earth. The iso_a3_eh column was added as a way to bridge this difference and be easier, though incorrect,
for most downstream users (similar to woe_id_eh). But looks like FRA wasn't set yet, and you probably also want to see an iso_a2_eh column I take it?

In any event, this particular issue was about a different thing (setting FR on the map unit level), so I'll create a new issue to track the new work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants