Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Norway ISO_A3_EH Code is -99 #252

Closed
nickpeihl opened this issue Mar 23, 2018 · 6 comments
Closed

Norway ISO_A3_EH Code is -99 #252

nickpeihl opened this issue Mar 23, 2018 · 6 comments

Comments

@nickpeihl
Copy link

There's been previous discussion about this and I think I understand the concerns about linking ISO codes to boundaries and why ISO_A3_EH was added. With that understood, could we add NOR to the ISO_A3_EH column for Norway? It's currently -99.

I'd be happy to submit a PR but I'm not sure if I need to update all the shapefiles attribute tables or if they each pull their attributes from a central location.

@enorazza
Copy link

enorazza commented Dec 4, 2018

What about ISO_A2?
Norway is totally missing the two characters code..
There already 7 different "NOR", but not a single "NO", which is very weird.
It is accepted as ISO A2 from 1974 as you can see here

@mentalstring
Copy link

Same for Portugal, where ISO_A2, ISO_A3 and ISO_A3_EH are all -99.

@pronebird
Copy link

Norway and France miss ISO_A2 codes. Any progress on fixing this? Seems trivial to fix.

@nvkelso nvkelso added this to the v5.0.0 milestone Oct 16, 2019
@nvkelso
Copy link
Owner

nvkelso commented Oct 16, 2019

Added this to the v5 milestone for the iso_a3_eh values.

@nvkelso
Copy link
Owner

nvkelso commented Oct 16, 2019

image

@nvkelso nvkelso closed this as completed Oct 16, 2019
@mvrhov
Copy link

mvrhov commented Oct 17, 2019

Well the iso_a2 is still missing on your screenshot.. and there is more replys where the ppl say that some others are also missing #284.
Thanks BTW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants