[Doc] Address symbolic link issue in nvm_die_on_prefix error message
#1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
changed the title
nvm_die_on_prefix error message
ljharb
reviewed
Jan 18, 2017
| @@ -2010,6 +2010,7 @@ nvm_die_on_prefix() { | |||
| else | |||
| nvm_err "Run \`$NVM_COMMAND\` to unset it." | |||
| fi | |||
| nvm_err "If \"$NVM_NPM_PREFIX\" is actually inside \"$NVM_DIR\" directory, please modify your NVM_DIR to make sure there is no any symbolic links." | |||
There was a problem hiding this comment.
This is fine, I think - although I wonder if there's any POSIX-compatible way this can be detected?
|
@MrOrz unfortunately it seems you've deleted your fork, so i can't rebase and land this. Any chance you could try to restore it, and recreate the branch? |
|
Hello @ljharb thanks for taking a look. I did a rebase and see that in master branch, Personally I did not encounter such issue for quite a few years, so I am not sure if I can reproduce the issue now. |
|
Now it's called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1385 .
Not sure if the wording is clear enough. Feel free to rephrase them!