Changed prefix check to work in case NVM_DIR is a link #2146
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cd -P` is in POSIX.
ljharb
requested changes
Jan 11, 2020
|
Duplicate of #2045. |
ljharb
reviewed
Jan 12, 2020
|
@ljharb is there anything missing? |
|
@GolanTrevize10 this is great, but it needs a test. can we add one? |
|
@GolanTrevize10 any chance you're able to add a test? |
ljharb
force-pushed
the
master
branch
2 times, most recently
from
c6cfc3a to
c20db2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When NVM_DIR is a link, nvm mistakenly returns the error
nvm is not compatible with the npm config "prefix" option: currently set to "/data/jenkins-misc/nvm/versions/node/v8.10.0"
Run
npm config delete prefixornvm use --delete-prefix v8.10.0to unset it.With this fix nvm will check correctly that the prefix is inside the NVM_DIR