Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodetimeline command #8

Merged
merged 5 commits into from
Oct 1, 2018
Merged

Add nodetimeline command #8

merged 5 commits into from
Oct 1, 2018

Conversation

bnb
Copy link
Collaborator

@bnb bnb commented Sep 30, 2018

This PR is a first pass at a nodetimeline command. Before writing docs I'd like to get feedback on the API 🙌

Two notes:

I initially had an --eol flag but it did not play well with line 67, which checks what the latest version is – it seems getEOL() doesn't return identical data to the others (which is fine!).

I could also add checking a specific version, but figured I'd get this up since it's starting to get a bit late and I've been working on this for a few hours now.

@bnb
Copy link
Collaborator Author

bnb commented Oct 1, 2018

Interestingly enough Node.js v10 is now returning isActive as true, contrary to what the README.md shows (and what should still be returned). Not sure if this is an issue or not 🤔

@nw
Copy link
Owner

nw commented Oct 1, 2018

Interestingly enough Node.js v10 is now returning isActive as true, contrary to what the README.md shows (and what should still be returned). Not sure if this is an issue or not 🤔

Two issues at play here:

  • The schedule.json in nodejs/release repo indicates v10 goes into active LTS on Oct 1st (monday).
  • There appears to be a slight rounding error with dates. It rounds to the closest day. Which for most purposes is fine, it just gets awkward in situations like this.

@nw nw merged commit 7f8e938 into master Oct 1, 2018
@nw
Copy link
Owner

nw commented Oct 1, 2018

Fun little tool. LGTM👍

Let's wait to see what happens tomorrow before we publish a release. If it does I need to start tracking v11.

@bnb
Copy link
Collaborator Author

bnb commented Oct 1, 2018

Created an issue to check in on v10: nodejs/Release#361

I’ll shoot over a PR including docs for nodetimeline later today 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants