disable remote debugging for non-sdk build #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerwang
force-pushed
the
nw14
branch
2 times, most recently
from
d030cc4 to
078615d
Compare
|
close for rebasing |
rogerwang
pushed a commit
that referenced
this pull request
Dec 5, 2016
BUG=666663 Review-Url: https://codereview.chromium.org/2516453003 Cr-Commit-Position: refs/heads/master@{#433330} (cherry picked from commit 2c81990) Review URL: https://codereview.chromium.org/2514313002 . Cr-Commit-Position: refs/branch-heads/2924@{#21} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
GnorTech
pushed a commit
that referenced
this pull request
Jan 29, 2017
The URL of the distilled page is not necessarily the URL of the Reading List entry (in case of redirection). Store the URL of the page that was distilled in the database. This CL adds the field in ReadingListEntry. This field will be used in a next CL. BUG=682666 Review-Url: https://codereview.chromium.org/2647763005 Cr-Commit-Position: refs/heads/master@{#445063} (cherry picked from commit 695d0c6) Review-Url: https://codereview.chromium.org/2648293002 . Cr-Commit-Position: refs/branch-heads/2987@{#21} Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang
pushed a commit
that referenced
this pull request
Mar 11, 2017
…ink> CSS inclusion.
Win10 FRE's did not integrate with Polymer properly, and as a result,
<action-link>'s CSS was ignored. This caused .no-outline to be
ineffective, so blue border appears when such a link gets clicked.
This CL picks up tmartino@'s draft Polymer integration code, and fix
the bug. Details:
- Create <dom-module id="welcome-win10-inline">, which absorbs most of
the contents of inline.css (except <body> styles).
- Instantiate content <welcome-win10-inline>.
- inline.js: Add Polymer({is: 'welcome-win10-inline', ...}), and adapt
existing initialization code plus handlers.
- Key to include action-link CSS: <dom-module> requires
<style include="action-link">...</style>
- Fix centering: <dom-module> (see :host) has "display: inline-flex"
along colun direction with "align-item: flex-start". The <body> of
the main page becomes "display: flex" for centering.
BUG=697140
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2733433002
Cr-Commit-Position: refs/heads/master@{#454524}
(cherry picked from commit 7b22889)
Review-Url: https://codereview.chromium.org/2737443003 .
Cr-Commit-Position: refs/branch-heads/3029@{#21}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech
pushed a commit
that referenced
this pull request
Apr 26, 2017
Previously we only checked the initial resolution and assumed it was always large enough to start watch time reporting; clearly this is not true since YouTube offers a 140p format. Probably we also want to drop the minimum resolution to 200x140p, which I'll check with product about and handle in a followup CL. BUG=711792 TEST=new tests. Manual: force 140p, adapt above, verify watch time. Review-Url: https://codereview.chromium.org/2822543006 Cr-Commit-Position: refs/heads/master@{#464826} (cherry picked from commit 2540556) Review-Url: https://codereview.chromium.org/2819323002 . Cr-Commit-Position: refs/branch-heads/3071@{#21} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech
pushed a commit
that referenced
this pull request
Aug 5, 2017
[email protected] Change-Id: I14e19fe0afb879637661bef4f045cbd97eef8576 Reviewed-on: https://chromium-review.googlesource.com/584021 Reviewed-by: [email protected] <[email protected]> Cr-Commit-Position: refs/branch-heads/3163@{#21} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech
pushed a commit
that referenced
this pull request
Sep 14, 2017
[email protected] (cherry picked from commit 610e705) Bug: 761768 Change-Id: I3afec4b664403c9197265ec55e27d4f1b0f16d91 Reviewed-on: https://chromium-review.googlesource.com/650218 Reviewed-by: Alex Mineer <[email protected]> Reviewed-by: Selim Gurun <[email protected]> Commit-Queue: John Budorick <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#499641} Reviewed-on: https://chromium-review.googlesource.com/650467 Reviewed-by: John Budorick <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{#21} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech
pushed a commit
that referenced
this pull request
Oct 27, 2017
There are two metrics: (1) Toggle metric: will be logged each time the setting is toggled from enabled to disabled or vice versa. This provides us statistics on how often the preference is changed. (2) Startup metric: will be logged each time the user logs in. This provides us statistics on what percentage of users have the preference enabled. [email protected] (cherry picked from commit a5837cf) Bug: 772474, 672263 Change-Id: Ie0a405d6d1031d3e70e4d8c8b71c3533e04748fd Reviewed-on: https://chromium-review.googlesource.com/713035 Commit-Queue: Kyle Horimoto <[email protected]> Reviewed-by: Ryan Hansberry <[email protected]> Reviewed-by: Ilya Sherman <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#508700} Reviewed-on: https://chromium-review.googlesource.com/722116 Reviewed-by: Kyle Horimoto <[email protected]> Cr-Commit-Position: refs/branch-heads/3239@{#21} Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang
pushed a commit
that referenced
this pull request
Jan 29, 2018
[email protected] Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I03a900939019ad7caf95ea5a22aac1be704fbe45 Reviewed-on: https://chromium-review.googlesource.com/879399 Reviewed-by: Krishna Govind <[email protected]> Cr-Commit-Position: refs/branch-heads/3325@{#21} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech
pushed a commit
that referenced
this pull request
Mar 20, 2018
This is a reland of 5e06564 Original change's description: > Add the LaunchUninstallFlow() function > > This function uses automation to automatically write the name of a > program into the search box of the Apps & Features page. > > Bug: 717696 > Change-Id: Ifc6a1be295a3d06ac33f394dcf3fc4688bd4a907 > Reviewed-on: https://chromium-review.googlesource.com/907590 > Reviewed-by: Demetrios Papadopoulos <[email protected]> > Reviewed-by: Greg Thompson <[email protected]> > Commit-Queue: Patrick Monette <[email protected]> > Cr-Commit-Position: refs/heads/master@{#540209} TBR: [email protected], [email protected] Bug: 717696 Change-Id: I9048a36c52113311496abe5d2d5d1ac3fe3c79fc Reviewed-on: https://chromium-review.googlesource.com/944202 Reviewed-by: Patrick Monette <[email protected]> Commit-Queue: Patrick Monette <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#540296}(cherry picked from commit 10fd49a) Reviewed-on: https://chromium-review.googlesource.com/950182 Cr-Commit-Position: refs/branch-heads/3359@{#21} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang
pushed a commit
that referenced
this pull request
Apr 25, 2018
[email protected] Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I25412dca6a9dd1d5f669a0b2f0af25c60e2230d1 Reviewed-on: https://chromium-review.googlesource.com/1014243 Reviewed-by: Krishna Govind <[email protected]> Cr-Commit-Position: refs/branch-heads/3396@{#21} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang
pushed a commit
that referenced
this pull request
Jun 19, 2018
[email protected] Change-Id: Ic0f7bf28a44c3cae28b7c585f6fec08ae11cb604 Reviewed-on: https://chromium-review.googlesource.com/1076353 Reviewed-by: [email protected] <[email protected]> Cr-Commit-Position: refs/branch-heads/3440@{#21} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech
pushed a commit
that referenced
this pull request
Aug 4, 2018
BUG=831073 [email protected] [email protected] (cherry picked from commit c0d2e5e) Change-Id: I99d07c42aa30e73f1efb878b97e4909aeae5ad7d Reviewed-on: https://chromium-review.googlesource.com/1144822 Reviewed-by: Mike West <[email protected]> Commit-Queue: Jochen Eisinger <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#576860} Reviewed-on: https://chromium-review.googlesource.com/1147222 Reviewed-by: Jochen Eisinger <[email protected]> Cr-Commit-Position: refs/branch-heads/3497@{#21} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang
pushed a commit
that referenced
this pull request
Sep 15, 2018
Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/35t5cJQ3J_Q/FH45dl0vAwAJ [email protected] (cherry picked from commit 4b736aa) Bug: 794548, 879994 Change-Id: Ie87aedd0027921960ff429d5d8ecf168572c82de Reviewed-on: https://chromium-review.googlesource.com/1199068 Commit-Queue: Mike West <[email protected]> Reviewed-by: Daniel Vogelheim <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#588364} Reviewed-on: https://chromium-review.googlesource.com/1203972 Reviewed-by: Mike West <[email protected]> Cr-Commit-Position: refs/branch-heads/3538@{#21} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang
pushed a commit
that referenced
this pull request
Oct 31, 2018
This reverts commit a12ef84. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 599001 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYTEyZWY4NDdhNTdmNGFhMDI4MmNhNDdiNTU1YzA0ZGExOGIwMGY5ZQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29516 Sample Failed Step: content_browsertests Sample Flaky Test: BrowserSideFlingBrowserTest.TouchscreenFlingBubblesFromOOPIF Original change's description: > Fling bubbles from OOPIF properly. > > While we are bubbling a scroll sequence GFS is sent to the fling controllers > of both the oopif and the bubbling target. The fling controller of the oopif > calls progressFling and generates a GSU with inertial phase, the GSU gets acked > immediately before getting sent to the renderer since we are in bubbling mode. > Then the oopif's fling controller receives the unconsumed GSU ack and generates > a GSE to complete the scrolling sequence on the oopif. The bubbling target's > fling controller receives and processes the GFS and generates GSUs which are > sent to the target's renderer. > > If the GSE generated by the oopif's fling controller gets bubbled before > the GFS, the bubbling target gets reset and the target does not receive the > GFS. This cl fixes the issue by making sure that the events generated by the > oopif's fling controller are not bubbled to the target. Also in case of > GFS bubbling, the GFC should also get sent to the bubbling target to make > sure that the fling controller in charge of flinging receives the GFC. > > > Bug: 884728, 249063 > Test: BrowserSideFlingBrowserTest.[Touchpad|Touchscreen]FlingBubblesFromOOPIF > Change-Id: I064944f125bebcb746f329af4cfb117f3be94ff0 > Reviewed-on: https://chromium-review.googlesource.com/c/1274193 > Reviewed-by: Kevin McNee <[email protected]> > Reviewed-by: Charlie Reis <[email protected]> > Commit-Queue: Charlie Reis <[email protected]> > Cr-Commit-Position: refs/heads/master@{#599001} Change-Id: Ie8178e456d50cdd43fdeb86939180d20b96bcc36 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 884728, 249063, 894703 Reviewed-on: https://chromium-review.googlesource.com/c/1278536 Cr-Original-Commit-Position: refs/heads/master@{#599094}(cherry picked from commit bb03212) Reviewed-on: https://chromium-review.googlesource.com/c/1280621 Reviewed-by: Sahel Sharify <[email protected]> Cr-Commit-Position: refs/branch-heads/3578@{#21} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang
pushed a commit
that referenced
this pull request
Dec 18, 2018
[email protected] Change-Id: I1469b8da1b66f43c686d8542c81da05147a0e8d4 Reviewed-on: https://chromium-review.googlesource.com/c/1359695 Reviewed-by: [email protected] <[email protected]> Cr-Commit-Position: refs/branch-heads/3626@{#21} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang
pushed a commit
that referenced
this pull request
Feb 10, 2019
The metrics inludes usage counters for the RTCQuicTransport, RTCIceTransport and RTCQuicStream APIs. This also includes histogram metrics for the readInto() and write() RTCQuicStream methods, recording the amount of bytes as well as an enum for how bytes are read/written. Bug: 874296 Change-Id: I53036a9e0c477b98ab52e32484b1fb472140c305 Reviewed-on: https://chromium-review.googlesource.com/c/1435074 Reviewed-by: Kentaro Hara <[email protected]> Reviewed-by: Steve Anton <[email protected]> Reviewed-by: Ilya Sherman <[email protected]> Commit-Queue: Seth Hampson <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#625970}(cherry picked from commit bbc9278) Reviewed-on: https://chromium-review.googlesource.com/c/1437322 Cr-Commit-Position: refs/branch-heads/3683@{#21} Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang
pushed a commit
that referenced
this pull request
Mar 24, 2019
Some apps specify a custom shape of their window, which is not implemented yet in DesktopWindowTreeHostMus. This CL implements the mojo API to support this scenario. See the bug for the actual apps and their usage. This CL does not solve all of the reported problems but fixes some. Bug: 935780 Test: new unit tests Change-Id: Ia39f0fc135093f63abd3031cdba43901fccfa09b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493031 Reviewed-by: Tom Sepez <[email protected]> Reviewed-by: Scott Violet <[email protected]> Reviewed-by: Michael Wasserman <[email protected]> Commit-Queue: Jun Mukai <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#639105}(cherry picked from commit 4cc40a6e754c373479e00ac3720b5657c530b104) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516057 Reviewed-by: Jun Mukai <[email protected]> Cr-Commit-Position: refs/branch-heads/3729@{#21} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed nwjs/nw.js#3620