activate window before showing dialogs #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bounds of dialogs are calcuated based on the bounds of parent window. However on Windows, when window is minized, the bounds returned from system is empty. Implementing `WebContentsDelegate::ActivateContents` in `AppWindow` to activate the native window before showing dialog fixes the issue. fixed nwjs/nw.js#4992
rogerwang
force-pushed
the
nw14
branch
2 times, most recently
from
954e187 to
c661222
Compare
rogerwang
pushed a commit
that referenced
this pull request
Sep 7, 2016
In the delayed activation of input connection, we call requestFocus() on proxy view, and this triggers HwSecImmHelper.isPasswordInputType() on Huawei phone, which in turn calls View#onCreateInputConnection() so there is an infinite loop, which eventually causes stackoverflow. Presumably isPasswordInputType() is only concerned about whether onCreateInputConnection()'s outAttrs.inputType is password type or not, so we fill out outAttrs.inputType and early out when there is a reentrance. BUG=636197 Review-Url: https://codereview.chromium.org/2246833002 Cr-Commit-Position: refs/heads/master@{#415220} (cherry picked from commit f5feceb) Review URL: https://codereview.chromium.org/2288223005 . Cr-Commit-Position: refs/branch-heads/2840@{#31} Cr-Branched-From: 1ae106d-refs/heads/master@{#414607}
|
Please also review this backport for nw14 |
rogerwang
pushed a commit
that referenced
this pull request
Dec 5, 2016
BUG=588377, 666980 Review-Url: https://codereview.chromium.org/2513083002 Cr-Commit-Position: refs/heads/master@{#433338} (cherry picked from commit 40b3059) Review URL: https://codereview.chromium.org/2515193003 . Cr-Commit-Position: refs/branch-heads/2924@{#31} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
GnorTech
pushed a commit
that referenced
this pull request
Jan 29, 2017
BUG=653425 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2648843002 Cr-Commit-Position: refs/heads/master@{#445291} (cherry picked from commit ac3b36a) Review-Url: https://codereview.chromium.org/2647413002 . Cr-Commit-Position: refs/branch-heads/2987@{#31} Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang
pushed a commit
that referenced
this pull request
Mar 11, 2017
This reverts commit 1ffffb4. [email protected],[email protected] BUG=696528 Review-Url: https://codereview.chromium.org/2739533002 . Cr-Commit-Position: refs/branch-heads/3029@{#31} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech
pushed a commit
that referenced
this pull request
Apr 26, 2017
Merge to M-59 branch. When a composited element with a border-radius overflow parent has border radius and overflows itself, the element's clip rect is included on the mask layer for the parent, which causes incorrect clipping of sibling content. Unfortunately a ref test fails due to a single pixel different on the border radius. [email protected] BUG=709533 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2821733002 Cr-Original-Commit-Position: refs/heads/master@{#465028} Review-Url: https://codereview.chromium.org/2825743002 . Cr-Commit-Position: refs/branch-heads/3071@{#31} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech
pushed a commit
that referenced
this pull request
Aug 5, 2017
[email protected] (cherry picked from commit ac104bc) Bug: 748068 Change-Id: If9ead9fc7330d0dc53e144d6f0d37fb47d9b8644 Reviewed-on: https://chromium-review.googlesource.com/583293 Commit-Queue: Justin Donnelly <[email protected]> Reviewed-by: Mark Pearson <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#489017} Reviewed-on: https://chromium-review.googlesource.com/585360 Reviewed-by: Justin Donnelly <[email protected]> Cr-Commit-Position: refs/branch-heads/3163@{#31} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech
pushed a commit
that referenced
this pull request
Sep 14, 2017
Adds missing ContextFactoryObserver::OnLostResources() implementation that is required for when GLHelper is destroyed/re-created because the current ReadbackYUVPipeline instance is no longer valid. [email protected] Bug: 760251 Change-Id: I85f54b60b32501aa3e08e1dcca7891ce739a913a Reviewed-on: https://chromium-review.googlesource.com/647409 Reviewed-by: Yuri Wiitala <[email protected]> Cr-Commit-Position: refs/heads/master@{#499354} Repair unit test broken by recent AuraWindowCaptureMachine crash fix. The recent crash fix broke a unit test that runs only on CrOS. The breakage was simply because the unit test never created an ImageTranportFactory instance. This change rectifies that. [email protected],[email protected] Bug: 760251 Change-Id: Ib1e4e72918bdda6b5e0d202507a28e6563239be7 Reviewed-on: https://chromium-review.googlesource.com/647493 Reviewed-by: Yuri Wiitala <[email protected]> Commit-Queue: Yuri Wiitala <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#499404} Reviewed-on: https://chromium-review.googlesource.com/651387 Cr-Commit-Position: refs/branch-heads/3202@{#31} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech
pushed a commit
that referenced
this pull request
Oct 27, 2017
Bug: 774601 Change-Id: I9bb19d3ecacc57df5918e24f5c5b940fbd136a4d Reviewed-on: https://chromium-review.googlesource.com/719880 Reviewed-by: Theresa <[email protected]> Commit-Queue: Becky Zhou <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#508872}(cherry picked from commit 73dde0d) Reviewed-on: https://chromium-review.googlesource.com/723640 Cr-Commit-Position: refs/branch-heads/3239@{#31} Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang
pushed a commit
that referenced
this pull request
Jan 29, 2018
This reverts commit 80428a9. AV1 is not ready for the beta channel. Disable it on the M65 branch. BUG=804400 Change-Id: I202d23e7ef4a495f9e65d9891fc605265fc90eb5 Reviewed-on: https://chromium-review.googlesource.com/878922 Reviewed-by: Dale Curtis <[email protected]> Cr-Commit-Position: refs/branch-heads/3325@{#31} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech
pushed a commit
that referenced
this pull request
Mar 20, 2018
[email protected] Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I36ae63f16301932d20d704b44f22b50834cff086 Reviewed-on: https://chromium-review.googlesource.com/951406 Reviewed-by: Krishna Govind <[email protected]> Cr-Commit-Position: refs/branch-heads/3359@{#31} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang
pushed a commit
that referenced
this pull request
Apr 25, 2018
The non-GeometryMapper code path was already implemented in this way. Bug:832870 [email protected] (cherry picked from commit f068aac) Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If85f93113b737a749658c274c6d6ab9afa408362 Reviewed-on: https://chromium-review.googlesource.com/1013399 Commit-Queue: Chris Harrelson <[email protected]> Reviewed-by: Xianzhu Wang <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#550903} Reviewed-on: https://chromium-review.googlesource.com/1014604 Cr-Commit-Position: refs/branch-heads/3396@{#31} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang
pushed a commit
that referenced
this pull request
Jun 19, 2018
This improves accessiblity of the infobar and makes it consistent with Desktop. Bug: 846888 Change-Id: I9e696898d9b43e9b73fcdfab5c451f9164444627 Reviewed-on: https://chromium-review.googlesource.com/1073912 Commit-Queue: Mathieu Perreault <[email protected]> Reviewed-by: Mathieu Perreault <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#562154}(cherry picked from commit a7194fc) Reviewed-on: https://chromium-review.googlesource.com/1077028 Reviewed-by: Moe Ahmadi <[email protected]> Cr-Commit-Position: refs/branch-heads/3440@{#31} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech
pushed a commit
that referenced
this pull request
Aug 4, 2018
Once an idle event is received, UserActivityManager will call a smart dim model to predict whether the upcoming dim should be deferred. The smart dim model currently does nothing. It will be implemented to make prediction in a later cl. The purpose of this cl is to set up the structure, specifically how various classes work together. This cl also contains the following changes: 1. All data that are used in prediction and logging now live in UserActivityEvent. - This makes prediction and logging simpler as all data are now in one place. 2. Add additional metrics to log (i). Model prediction data. (ii). Previous positive and negative actions count. - They were derived data from other logged data. They are used as prediction features, and we log them directly now to avoid training-serving skew. 3. Stop logging several tab-related metrics logged, this will significantly reduce data logged. - Also only log one active tab in the focused/topmost browser that's visible. 4. Add a flag to disable/enable prediction. - It's disabled by default but will be set in experiments later. Bug: 862461 Change-Id: I7770efdfb5f15679fc4b49f8bf892292e7a347fc Reviewed-on: https://chromium-review.googlesource.com/1132828 Reviewed-by: Dan Erat <[email protected]> Reviewed-by: Steven Holte <[email protected]> Commit-Queue: Jia Meng <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#576808}(cherry picked from commit 7332829) Reviewed-on: https://chromium-review.googlesource.com/1147620 Reviewed-by: Jia Meng <[email protected]> Cr-Commit-Position: refs/branch-heads/3497@{#31} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang
pushed a commit
that referenced
this pull request
Sep 15, 2018
In data reduction proxy, the prober waits a little while before probing a proxy. This CL changes the interval between retries, and also makes it possible to configure that interval using field trial params. Change-Id: I9bd4ca39759d69aff5c5658fd34678b9722b8961 Bug: 849292 Reviewed-on: https://chromium-review.googlesource.com/1195152 Reviewed-by: Scott Little <[email protected]> Commit-Queue: Tarun Bansal <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#588055}(cherry picked from commit 22730e4) Reviewed-on: https://chromium-review.googlesource.com/1204912 Reviewed-by: Tarun Bansal <[email protected]> Cr-Commit-Position: refs/branch-heads/3538@{#31} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang
pushed a commit
that referenced
this pull request
Oct 31, 2018
…helf Transient Crostini windows are supposed to be filtered from the shelf, but we are checking for a transient parent on window Init, which is before it actually gets set. This was causing a UAF on profile switching as MultiUserWindowManagerChromeOS::SetWindowOwner() is not supposed to be called with transient windows. Bug: 845843 Change-Id: Iec7b48cb03fff22775c31ce08c398ba750836463 Reviewed-on: https://chromium-review.googlesource.com/c/1266475 Commit-Queue: Timothy Loh <[email protected]> Reviewed-by: Michael Wasserman <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#599038}(cherry picked from commit bf10ece) Reviewed-on: https://chromium-review.googlesource.com/c/1282083 Reviewed-by: Timothy Loh <[email protected]> Cr-Commit-Position: refs/branch-heads/3578@{#31} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang
pushed a commit
that referenced
this pull request
Dec 18, 2018
This allows the 32-bit build of the shared library to overwrite the one built via the 64-bit build. Bug: 908115, 893125 Change-Id: I0ede727cfced2dd5285f75594f08b8c3450e8a27 Reviewed-on: https://chromium-review.googlesource.com/c/1357312 Reviewed-by: Tao Bai <[email protected]> Reviewed-by: agrieve <[email protected]> Commit-Queue: Ben Mason <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#613296}(cherry picked from commit 6917b4e) Reviewed-on: https://chromium-review.googlesource.com/c/1361294 Reviewed-by: Ben Mason <[email protected]> Cr-Commit-Position: refs/branch-heads/3626@{#31} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang
pushed a commit
that referenced
this pull request
Feb 10, 2019
…ome OS by default"" This reverts commit 233c771. Reason for revert: crbug.com/925705 Original change's description: > Reland "media/gpu/VEA unittest: Verify encoded content on Chrome OS by default" > > VEA unittest verifies VEA's encoding content by > 1. decode content by FFmepgVideoDecoder > 2. compare it with the original VideoFrame and computes SSIM > 3. check the SSIM less than or equal to the predetermined threshold, 10.0. > > VEA unittest turns on this verifitcation by --verify_all_output and one of test > case parameters. This verification was always disabled on Chrome OS by setting > --verify_all_output false because of https://crbug.com/694131. I think the bug > is already fixed. We can re-enable the verification on Chrome OS now by default. > > [email protected] > > Bug: 923762 > Test: VEA unittest on eve > Change-Id: I597346a9ecd114ccc37ebde1ab284b97103a6e4f > Reviewed-on: https://chromium-review.googlesource.com/c/1429307 > Reviewed-by: Hirokazu Honda <[email protected]> > Commit-Queue: Hirokazu Honda <[email protected]> > Cr-Commit-Position: refs/heads/master@{#625101} [email protected] # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 923762 Change-Id: If8863bcbca29a3b78b36a208bff07bc90896a319 Reviewed-on: https://chromium-review.googlesource.com/c/1438674 Reviewed-by: David Staessens <[email protected]> Commit-Queue: Hirokazu Honda <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#626423}(cherry picked from commit f10847e) Reviewed-on: https://chromium-review.googlesource.com/c/1441658 Reviewed-by: Hirokazu Honda <[email protected]> Cr-Commit-Position: refs/branch-heads/3683@{#31} Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang
pushed a commit
that referenced
this pull request
Mar 24, 2019
This CL collects the final position (coarse) that a PIP window was moved to. Bug: b/121299293 Test: unit test Change-Id: Ic5ced2c17fb0901c73abd0da55ef1cb6e654976d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1477551 Reviewed-by: Mitsuru Oshima <[email protected]> Reviewed-by: Jesse Doherty <[email protected]> Commit-Queue: Eliot Courtney <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#639303}(cherry picked from commit 1318ed0e6a53c420a42371618a3d7db89506fcc4) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517175 Reviewed-by: Eliot Courtney <[email protected]> Cr-Commit-Position: refs/branch-heads/3729@{#31} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bounds of dialogs are calcuated based on the bounds of parent window.
However on Windows, when window is minized, the bounds returned from
system is empty.
Implementing
WebContentsDelegate::ActivateContentsinAppWindowtoactivate the native window before showing dialog fixes the issue.
fixed nwjs/nw.js#4992
backport from PR #30