Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flash flickering of console window "echo NOT SANDBOXED" fix #67

Closed
wants to merge 2 commits into from
Closed

Flash flickering of console window "echo NOT SANDBOXED" fix #67

wants to merge 2 commits into from

Conversation

janRucka
Copy link
Contributor

@janRucka janRucka commented Mar 3, 2017 •
edited
Loading

When flash was first used on Windows then console windows with "echo NOT SANDBOXED" flickered.

See:
nwjs/nw.js#5278

Our project:
https://groups.google.com/forum/#!topic/nwjs-general/TmZUq-JHIuQ

@rogerwang rogerwang changed the base branch from nw19 to nw21 March 8, 2017 02:42
@rogerwang rogerwang changed the base branch from nw21 to nw19 March 8, 2017 02:42
rogerwang pushed a commit that referenced this pull request Mar 11, 2017
@rdcronin
[Extensions] Don't allow setting an opener outside of the same window
20ec407 
Extensions can set a tab's opener (as seen by the tab strip model) using
different APIs. However, the TabStripModel only updates openers (such as
when the tab is removed) for tabs that it contains. This meant that if
an extension set an opener to a tab that wasn't within the
TabStripModel, subsequent queries or events would fail when we tried to
look up the opener id.

Don't allow extensions to set an opener outside of the owning
TabStripModel.

Note: this is intentionally a small change, which unfortunately means we
aren't handling all cases as gracefully as possible. However, it's low-
risk, and should stop us from crashing.

BUG=698681

Review-Url: https://codereview.chromium.org/2737103002
Cr-Commit-Position: refs/heads/master@{#455355}
(cherry picked from commit 5b3827b)

Review-Url: https://codereview.chromium.org/2740763002 .
Cr-Commit-Position: refs/branch-heads/3029@{#67}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
@rogerwang
Copy link
Member

merged into the master patch with copyright notice.

@rogerwang rogerwang closed this Mar 16, 2017
@rogerwang rogerwang reopened this Mar 16, 2017
rogerwang
rogerwang reviewed Mar 16, 2017
View reviewed changes
base/native_library_win.cc Outdated
return true;
}

BOOL WINAPI ReplaceFunctionAddressInModule(HMODULE module, PROC origFunc, PROC newFunc) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It failed to compile on some platforms (64bit, or nacl) due to warnings:
http://buildbot-master.node-webkit.org:8010/builders/nw21_win64/builds/32/steps/ninja_release/logs/stdio
http://buildbot-master.node-webkit.org:8010/builders/nw21_sdk_win32/builds/31/steps/ninja_release/logs/stdio

And please use base::win::IATPatchFunction rather than using own code for patching.

@janRucka
Copy link
Contributor Author

Good idea with base::win::IATPatchFunction unfortunately I have some problems with that. Hopefully will solve next week. After I tried it I have to admit our solution is no good for x64 (at least yet) we didn't find out since we use just x86...

rogerwang and others added 2 commits March 21, 2017 15:40
@rogerwang
nwjs master
319d6c0
@janRucka
Flash fix:
4632f04 
When flash was first used on Windows then console windows with "echo NOT SANDBOXED" flickered.
@janRucka janRucka changed the base branch from nw19 to nw21 March 27, 2017 14:24
@janRucka
Copy link
Contributor Author

Updated, now based on nw21 with use of "IATPatchFunction" as you advised. It should compile (and work) with x64 as well. We even find and fix small issue in the process.

@rogerwang rogerwang force-pushed the nw21 branch 2 times, most recently from da3929b to b060cdf Compare March 28, 2017 04:57
@rogerwang
Copy link
Member

merged into the master patch. thanks.

@rogerwang rogerwang closed this Mar 28, 2017
GnorTech pushed a commit that referenced this pull request Apr 26, 2017
Record UMA when Data Reduction stats are reset via the settings menu
254bd12 
BUG=702799

Review-Url: https://codereview.chromium.org/2821593002
Cr-Commit-Position: refs/heads/master@{#465306}
(cherry picked from commit b38d7e9)

Review-Url: https://codereview.chromium.org/2830913002 .
Cr-Commit-Position: refs/branch-heads/3071@{#67}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech pushed a commit that referenced this pull request Aug 5, 2017
Fixed webViewLoadingStateDidChange crash.
ad74fc6 
webViewLoadingStateDidChange crashes on dereferencing a null pointer.
It is unknown how app gets into this state, but registering another load
request is a better option than crashing.

[email protected]

(cherry picked from commit 541f046)

(cherry picked from commit 3046ee1)

Bug: 737595
Change-Id: Ibbe66fe5689722fea2de205d07871f3dacec136a
Reviewed-on: https://chromium-review.googlesource.com/585864
Reviewed-by: Kurt Horimoto <[email protected]>
Commit-Queue: Eugene But <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#489537}
Reviewed-on: https://chromium-review.googlesource.com/586926
Reviewed-by: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/3112@{#673}
Cr-Original-Branched-From: b6460e2-refs/heads/master@{#474897}
Reviewed-on: https://chromium-review.googlesource.com/587713
Cr-Commit-Position: refs/branch-heads/3163@{#67}
Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech pushed a commit that referenced this pull request Sep 14, 2017
@denniskempin
Fix coalesced Touch Event Timestamp
eda8f58 
This patch fixes the timestamp of generated coalesced touch events.

[email protected]

(cherry picked from commit 1efe715)

Bug: 761091
Change-Id: Iddaf8e61dbc52d0a23cc3543768482d341d7b9eb
Reviewed-on: https://chromium-review.googlesource.com/649906
Reviewed-by: Navid Zolghadr <[email protected]>
Reviewed-by: Dave Tapuska <[email protected]>
Commit-Queue: Jingkui Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#499647}
Reviewed-on: https://chromium-review.googlesource.com/655759
Reviewed-by: Dennis Kempin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#67}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech pushed a commit that referenced this pull request Oct 27, 2017
@dtsengchromium
[Merge to m63] selectstart event dispatch requires a valid node
8348a33 
[email protected]

(cherry picked from commit c783ff1)

Bug: 775320
Test: manual.
Change-Id: I763adcb2ff287cb4594984eec3d494ff93fb8f10
Reviewed-on: https://chromium-review.googlesource.com/723787
Reviewed-by: Dominic Mazzoni <[email protected]>
Commit-Queue: David Tseng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509628}
Reviewed-on: https://chromium-review.googlesource.com/728399
Reviewed-by: David Tseng <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#67}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang pushed a commit that referenced this pull request Jan 29, 2018
[Upstream] Use DISTANCE_BUBBLE_PREFERRED_WIDTH in the credit card upl…
9bdbe40 
…oad bubble

Bug: 800997
Change-Id: I568a3038fbc1874a148199daaf1cd5f8b416ef5f
Reviewed-on: https://chromium-review.googlesource.com/879170
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Jared Saul <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#530996}(cherry picked from commit 8d2fb44)
Reviewed-on: https://chromium-review.googlesource.com/884325
Reviewed-by: Jared Saul <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#67}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
[Merge to M66] Cros splitscreen: Use current screen orientation inste…
5dd5b5f 
…ad of cached screen orientation when calculating snapped window bounds.

It's possible that there is a dismatch between the current screen
orientation and the cached screen orientation in SplitViewController.

Bug: 799609
[email protected]

(cherry picked from commit 57903fc)

Change-Id: I484324e4716b51239c40a9d482f9b7f85ced0627
Reviewed-on: https://chromium-review.googlesource.com/947665
Commit-Queue: Xiaoqian Dai <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#541001}
Reviewed-on: https://chromium-review.googlesource.com/953136
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#67}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
@rosetta-jpn
media/gpu/v4l2vda: Execute NotifyFlushDone for Flush if input stream …
3527d48 
…is off

VDA client can request Flush() after Reset() and waits for NotifyFlushDone().
After FinishReset() is done, input stream becomes off. Even doing V4L2_DEC_CMD_STOP
at this time, the buffer with V4L2_BUF_FLAG_LAST will never be returned from
driver. As a result, NotifyFlushDone() will not be invoked and client waits
permanently.
To avoid this, V4L2VDA is changed as it tries to call NotifyFlushDone if input
stream is off.

BUG=chromium:833223, chromium:833221
TEST=Change resolution manually on crosvideo.appspot.com
TEST=VDA unittest on hana
TEST=CtsMediaTestCases on hana

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4245bdcee1e537dc7061e7833530ae59fc4aecb7
Reviewed-on: https://chromium-review.googlesource.com/1013802
Reviewed-by: Pawel Osciak <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#67}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request Jun 19, 2018
Roll chromite in DEPS to 5c5c9b6bb
1408f3c 
BUG=chromium:848082
TEST=None

Change-Id: I7202c78124b77c1124f35c9516f427b9b638428e
Reviewed-on: https://chromium-review.googlesource.com/1081293
Reviewed-by: Ken Rockot <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#67}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech pushed a commit that referenced this pull request Aug 4, 2018
[unified-consent] Add sign-in-again button when sync is paused
6a598d7 
When sync is paused, i.e. the user is in an auth error, the
syncSetup page now has a button to sign in again to resolve
the error.

Mocks:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZWnUS9sdsb0Q/files/MCHtA7U1iMGr664Bt8FBOxWEyjSSOyFCbW0

Bug: 856210
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Iab413fb69fcabff076f3c48d3b828dea05df6229
Reviewed-on: https://chromium-review.googlesource.com/1138619
Commit-Queue: Thomas Tangl <[email protected]>
Reviewed-by: Scott Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#577144}(cherry picked from commit d229bab)
Reviewed-on: https://chromium-review.googlesource.com/1149961
Reviewed-by: Thomas Tangl <[email protected]>
Cr-Commit-Position: refs/branch-heads/3497@{#67}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
@sebsg
Merge-70 [AF] Get account from PDM instead of IdentityManager
590bda6 
Actually Two changes bundled here

1) Get account from Personal data manager instead of IdentityManager
2) (Small helper method) Personal datamanager changes to denote fullsync user or not that can be propagated to rest of the Autofill module.
Goal is to send it to payment RPCs.

[email protected]

(cherry picked from commit 7ba5ea8)

Bug: 880861, 840703
Change-Id: I61422018c9fe6755f7315ccc692ab6245ed754da
Reviewed-on: https://chromium-review.googlesource.com/1184030
Commit-Queue: Sebastien Seguin-Gagnon <[email protected]>
Reviewed-by: Mathieu Perreault <[email protected]>
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Reviewed-by: David Roger <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#588608}
Reviewed-on: https://chromium-review.googlesource.com/1208137
Cr-Commit-Position: refs/branch-heads/3538@{#67}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
@jacobdufault-google
cros: Remove unneeded "Add fingerprint" button on OOBE
b3e7f5e 
This code is only used in OOBE so it is safe to just remove it.

[email protected]

(cherry picked from commit 35bbced)

Bug: 890367
Change-Id: I54130cc3c115c1a1356a045f443a8a19962686f8
Reviewed-on: https://chromium-review.googlesource.com/c/1279162
Reviewed-by: Alexander Alekseev <[email protected]>
Commit-Queue: Jacob Dufault <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599381}
Reviewed-on: https://chromium-review.googlesource.com/c/1284692
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#67}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
@beaufortfrancois
[Picture-in-Picture] Show last frame when video ends
84a3578 
This PR makes sure the last video frame stays visible in the PiP window
when video ends. This is what <video> elements currently do inline.

Bug: 910433
Change-Id: Id6a2065146ca4c76828f3257cd3ee2af7c2eed1b
Reviewed-on: https://chromium-review.googlesource.com/c/1356707
Reviewed-by: Tommy Steimel <[email protected]>
Reviewed-by: Jochen Eisinger <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Commit-Queue: Mounir Lamouri <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#613343}(cherry picked from commit fdfc67c)
Reviewed-on: https://chromium-review.googlesource.com/c/1361709
Reviewed-by: François Beaufort <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#67}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
[Merge M73][NTP] Add API for search suggestion selected
c512110 
window.chrome.embeddedSearch.newTabPage.searchSuggestionSelected(task_version, task_id, hash)

When a search suggestion is selected clear the cached data and issue
a new request. For only this request we append the selected suggestion
to the blocklist. This prevents a race condition where the request
completes before the data server side is updated to reflect the
selection, resulting in the same suggestion appearing in the next set.

Bug: 904565
Change-Id: Ie322f0efdfc23618c0b8455695d6790e434a30b2
Reviewed-on: https://chromium-review.googlesource.com/c/1422397
Commit-Queue: Kyle Milka <[email protected]>
Reviewed-by: Chris Palmer <[email protected]>
Reviewed-by: Kristi Park <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#626757}(cherry picked from commit 9132e5f)
Reviewed-on: https://chromium-review.googlesource.com/c/1446557
Reviewed-by: Kyle Milka <[email protected]>
Cr-Commit-Position: refs/branch-heads/3683@{#67}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
Incrementing VERSION to 74.0.3729.9
1606ed6 
[email protected]

Change-Id: Id3ff57736b833a8f142924968467e9c49e898b48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519104
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3729@{#67}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogerwang rogerwang rogerwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janRucka @rogerwang