[Transparency][Win] Fix #6046, Fix #6176 #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #6046, transparent background became black on win7 user switching, fixed by DwmExtendFrameIntoClientArea on UpdateDWMFrame(), Fix #6176 where some transparent region is not clickable, fixed by reverting WS_EX_LAYERED | WS_EX_COMPOSITED extended style
|
great. thanks |
|
merged into the master patch. |
GnorTech
pushed a commit
that referenced
this pull request
Oct 27, 2017
[email protected] (cherry picked from commit 32d2665) Bug: 768086 Change-Id: I89023223ff60736a7d51b7b143dd574b68d64fa5 Reviewed-on: https://chromium-review.googlesource.com/719412 Commit-Queue: Lucas Garron <[email protected]> Reviewed-by: Chris Bentzel <[email protected]> Reviewed-by: Lucas Garron <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#509799} Reviewed-on: https://chromium-review.googlesource.com/729214 Cr-Commit-Position: refs/branch-heads/3239@{#96} Cr-Branched-From: adb61db-refs/heads/master@{#508578}
GnorTech
pushed a commit
that referenced
this pull request
Dec 16, 2017
When the sign-in promo view is hidden (by collapsing the "Other Devices" section), Chrome crashes, if the sign-in promo view has to be reloaded (with a new identity added by another app for example). If the section is collapse the sign-in promo should not be updated. The view will be updated later when the user will uncollapse the section. [email protected] (cherry picked from commit 8448aff) Bug: 776939 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie68ba68e40580b510a782b54ec744865311ed2bb Reviewed-on: https://chromium-review.googlesource.com/811464 Commit-Queue: Jérôme Lebel <[email protected]> Reviewed-by: Gauthier Ambard <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#522407} Reviewed-on: https://chromium-review.googlesource.com/817558 Reviewed-by: Jérôme Lebel <[email protected]> Cr-Commit-Position: refs/branch-heads/3282@{#96} Cr-Branched-From: 5fdc0fa-refs/heads/master@{#520840}
rogerwang
pushed a commit
that referenced
this pull request
Jan 29, 2018
* Allow different timeout thresholds for secure and insecure proxies. * Use HTTP RTT for computing the proxy connection timeout instead of the transport RTT. Bug: 704339 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I6a2761a6dda90c53cdcc47045b05dcdc57e939e4 Reviewed-on: https://chromium-review.googlesource.com/845057 Commit-Queue: Tarun Bansal <[email protected]> Reviewed-by: Matt Menke <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#530713}(cherry picked from commit 162eabe) Reviewed-on: https://chromium-review.googlesource.com/887122 Reviewed-by: Tarun Bansal <[email protected]> Cr-Commit-Position: refs/branch-heads/3325@{#96} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech
pushed a commit
that referenced
this pull request
Mar 20, 2018
For bug 819556 we now believe it is more likely an IPC::Channel or RenderProcessHost host leak in some fashion. This CHECK is being hit by renderers. Although that's potentially interesting, it does not help us address the original bug. [email protected], [email protected] (cherry picked from commit 12b25d7) Bug: 819556,813045 Change-Id: I578d6b640815ec8d525df596a8b5d4843164d284 Reviewed-on: https://chromium-review.googlesource.com/953025 Reviewed-by: Ken Rockot <[email protected]> Commit-Queue: Ken Rockot <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#541416} Reviewed-on: https://chromium-review.googlesource.com/955669 Cr-Commit-Position: refs/branch-heads/3359@{#96} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang
pushed a commit
that referenced
this pull request
Apr 25, 2018
Create IOS.ITunesURLsStoreKitHandlingResult to Histogram to log the result of itunes url handling by storekit. Bug: 623016 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6a9b7db91743df90cc7f2af1e1e42567691618d4 Reviewed-on: https://chromium-review.googlesource.com/1010964 Commit-Queue: Mohammad Refaat <[email protected]> Reviewed-by: Eugene But <[email protected]> Reviewed-by: Ilya Sherman <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#551170}(cherry picked from commit 3d03e05) Reviewed-on: https://chromium-review.googlesource.com/1017361 Cr-Commit-Position: refs/branch-heads/3396@{#96} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang
pushed a commit
that referenced
this pull request
Jun 19, 2018
… the About page. [email protected] (cherry picked from commit b8fa6ef) Bug: 847007 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I865f56c836845d11b32aba7f4c12e43cd72a9d1a Reviewed-on: https://chromium-review.googlesource.com/1077073 Reviewed-by: Scott Chen <[email protected]> Commit-Queue: Demetrios Papadopoulos <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#562598} Reviewed-on: https://chromium-review.googlesource.com/1082929 Reviewed-by: Demetrios Papadopoulos <[email protected]> Cr-Commit-Position: refs/branch-heads/3440@{#96} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech
pushed a commit
that referenced
this pull request
Aug 4, 2018
This fixes an issue where an existing user's passwords are not saved in
the UserContext if views-based login is used. This in turn meant that
the user's password would not be saved in the kernel keyring in cases
where the ${PASSWORD} variable is used in the OpenNetworkConfiguration
policy.
BUG=chromium:866566
TEST=run unit tests, run autotests
Change-Id: I2d43ebfb6869d8d333e61505d1987081076fc3da
Reviewed-on: https://chromium-review.googlesource.com/1147207
Reviewed-by: Jacob Dufault <[email protected]>
Commit-Queue: May Lippert <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#577318}(cherry picked from commit 486c519)
Reviewed-on: https://chromium-review.googlesource.com/1150256
Reviewed-by: May Lippert <[email protected]>
Cr-Commit-Position: refs/branch-heads/3497@{#96}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang
pushed a commit
that referenced
this pull request
Sep 15, 2018
This allows chrome://settings/inputMethods to show up-to-date IME
information without closing and reopening the settings window. For
example, when the language X is enabled on the device and a new
Chrome OS IME extension for the language X is installed, it'll
instantly show up in chrome://settings/inputMethods. The same happens
for Android IMEs installed via Play Store too.
BUG=867795,845079
TEST=Add 'Japanese' to the language list, open chrome://settings/inputMethods,
install 'SKK Japanese Input' (extension IME) from Chrome Web Store, verify
the IME entry ('SKK') shows up in the settings page immediately.
TEST=Go to extensions page, disable the SKK IME, verify 'SKK' disappears
immediately.
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I20f7586cd58e7d6c6f92f37c1f0b697d57d17d32
Reviewed-on: https://chromium-review.googlesource.com/1198106
Commit-Queue: Yusuke Sato <[email protected]>
Reviewed-by: Michael Giuffrida <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#588233}(cherry picked from commit 13ed66f)
Reviewed-on: https://chromium-review.googlesource.com/1211863
Reviewed-by: Yusuke Sato <[email protected]>
Cr-Commit-Position: refs/branch-heads/3538@{#96}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang
pushed a commit
that referenced
this pull request
Oct 31, 2018
We have UsePaintRecordForImageSkia feature enabled for all platforms post m72. But this flag needs to be enabled for CrOS on m71 as ui-GPU rasterization for CrOS is being enabled in this milestone. The master branch change can be found here: https://chromium-review.googlesource.com/c/chromium/src/+/1279068 Bug: 894901 Change-Id: Iffc5ba99727aa155b7a6237ccab917fe6d7e0659 Component: Images, vector icons, Chrome OS Reviewed-on: https://chromium-review.googlesource.com/c/1281237 Reviewed-by: Mitsuru Oshima <[email protected]> Cr-Commit-Position: refs/branch-heads/3578@{#96} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang
pushed a commit
that referenced
this pull request
Dec 18, 2018
[email protected] Change-Id: I00f1030d0bdd588743843eaad5b3ddbfa8fdae49 Reviewed-on: https://chromium-review.googlesource.com/c/1364300 Reviewed-by: [email protected] <[email protected]> Cr-Commit-Position: refs/branch-heads/3626@{#96} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang
pushed a commit
that referenced
this pull request
Feb 10, 2019
Only part of the link was clickable, because another element appeared above it with higher z-index. Bug: 925849 Change-Id: Icc711036ea26208d66d4b660bac35456fb82b501 Reviewed-on: https://chromium-review.googlesource.com/c/1439843 Reviewed-by: Demetrios Papadopoulos <[email protected]> Commit-Queue: Nicolas Ouellet-Payeur <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#626629}(cherry picked from commit 03635a8) Reviewed-on: https://chromium-review.googlesource.com/c/1448702 Reviewed-by: Nicolas Ouellet-Payeur <[email protected]> Cr-Commit-Position: refs/branch-heads/3683@{#96} Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang
pushed a commit
that referenced
this pull request
Mar 24, 2019
…th ESC. This is another variant of the issue fixed by r637595. Instead of pressing the cancel button in the Print Preview UI, users can press the ESC key instead. In this case, the sequence of events is different, and PrintPreviewDialogDelegate::OnDialogClosed() gets called too late. To fix this, add ui::WebDialogDelegate::OnDialogClosingFromKeyEvent(), and call it when the ConstrainedDialogWebView sees the ESC key being pressed. In PrintPreviewDialogDelegate::OnDialogClosingFromKeyEvent(), call OnDialogClosed() to properly unblock the webpage. BUG=936542 TEST=Manual, see bug. [email protected] (cherry picked from commit d8349349837694b60c3c18c3e0e79431f950aa64) Change-Id: I0640ee7da86d407965ba6c6bbe3bbb17accf2ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515910 Reviewed-by: Avi Drissman <[email protected]> Commit-Queue: Lei Zhang <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#640026} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520318 Reviewed-by: Lei Zhang <[email protected]> Cr-Commit-Position: refs/branch-heads/3729@{#96} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nwjs/nw.js#6046, transparent background became black on win7 user switching, fixed by DwmExtendFrameIntoClientArea on UpdateDWMFrame(),
Fix nwjs/nw.js#6176 where some transparent region is not clickable, fixed by reverting WS_EX_LAYERED | WS_EX_COMPOSITED extended style
@rogerwang please also patch nw26