Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nwjs + MP3 special build for Europe? #4149

Closed
AndryBray opened this issue Jan 4, 2016 · 15 comments
Closed

nwjs + MP3 special build for Europe? #4149

AndryBray opened this issue Jan 4, 2016 · 15 comments

Comments

@AndryBray
Copy link

Hello,
I read about MP3 patent limits on new nwjs and as I read on wikipedia this codec is patent-free for Europe:

The basic MP3 decoding and encoding technology is patent-free in the European Union, all patents having expired there.
https://en.wikipedia.org/wiki/MP3#Licensing.2C_ownership_and_legislation

Please, could you add to your builds another one special for Europe companies? (something like nwjs-eu)
Thank you

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@ghostoy
Copy link
Member

ghostoy commented Jan 5, 2016

@AndryBray Currently we don't release NW with proprietary codecs like MP3 and H.264 because of license. But you can build NW with those codecs if you are eligible to use them. See Enable Proprietary Codecs.

@rogerwang
Copy link
Member

@ghostoy I think @AndryBray already knows that ... He is suggesting that since users don't need license for MP3 codec in Europe, we should include it in the official binary.

@ghostoy
Copy link
Member

ghostoy commented Jan 5, 2016

@rogerwang How about also providing official binary with all proprietary codecs for developers or company who is eligible to use them?

@AndryBray
Copy link
Author

It would be nice just to download the built package with proprietary codec.
As @ghostoy said, the company should care to choose which one is eligible to use.

@rogerwang how much time do you think we have to wait for this feature?
Thank you

solpie added a commit to solpie/animk that referenced this issue Jan 26, 2016
@night
Copy link

night commented Feb 15, 2016

@rogerwang Electron bundles proprietary codecs, so why doesn't nwjs? With ffmpegsumo gone you're leaving people to download and build nwjs, which is a massive amount of wasted time (downloading and compiling a 20G project) to set two flags on a build. There would be far less confusion and issues cropping up over this if it was just built in or at least included in a separate build.

@rogerwang
Copy link
Member

@night we'd like to. But we don't have any license to distribute the codecs in question. If we provide a build for application developers who have a license, that's still a violation.

@mscreenie
Copy link
Contributor

I agree rebuilding for the he sake of setting two flags is a real set back.

Is there an easier way? Loading externally?

@AndryBray
Copy link
Author

@rogerwang why don't you build over a mirror european server? that's not a violation as in Europe every patent is expired.

@rogerwang
Copy link
Member

We need to be careful verifying the information on wikipedia. In the mean time this issue is assigned to Kevin, who is not an Intel employee.

@abhijeetk
Copy link

@rogerwang How about providing JS API to enable codec ?

  • Enable all codecs supported by ffmpeg(including proprietary codecs)
  • by default disable proprietary codecs in chromium layer.
  • Allow user to enable proprietary codec at chromium layer using JS API. (It is responsibility of developer to enable it)

JS -----> chromium(disabled) ---> ffmpeg(enabled)

After enabling proprietary codec using JS API.(say, mp4)

windows.enableMimeType('video/mp4') ----> chromium(enabled) ---> ffmpeg(enabled)

Please let me know your opinion on this approach.

@AndryBray
Copy link
Author

@abhijeetk great idea!
👍

@tomekmarchi
Copy link

@abhijeetk love it

@GnorTech
Copy link
Member

GnorTech commented May 2, 2017

Since the patents on MP3 decoding are expired in the last month, NW.js should enable the mp3 decoding support.
https://en.wikipedia.org/wiki/MP3#Licensing.2C_ownership_and_legislation

@rogerwang
Copy link
Member

@abhijeetk the API idea won't work. The patent infringement happens when you redistribute the codec binary, not using it.

@rogerwang
Copy link
Member

Mp3 decoder is in official NW binary since 0.22.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants