-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DesktopCaptureMonitor desktop stream does not get AudioTrack #5029
Comments
@thedracle The feature heavily depends on Chrome's internal implementation. However Google is not planning to support audio tracks for screen cast on Linux and Mac (See crbug 223639). I will try to enable audio tracks for Windows only. |
Thanks :) I only need it on Windows for now. I was working on making a node module for grabbing Core Audio myself, but it's much better to have it as a stream that can be synced/sent with a video source. |
This change should appear in the following build, correct? I'm assuming because: http://dl.nwjs.io/live-build/06-30-2016/nw16-0a316ed-9a7d65c-1610340-77f39b5/v0.16.0/ I've tried the same getDesktopVideoStream example as above running it with similar results on Windows:
The result is still '[]', no audio tracks. @ghostoy Did you see something different, or do you have a test/constraints I can use that produces an audio stream on Windows? |
Doing some more of my own testing on Chrome 51.0.2704.103 m on Windows 10 and Windows 7, it appears even as a Chrome extension the behavior is the same-- I.E an upstream issue maybe, or an API change of some kind? It seems to indicate this works in Windows on Chrome 39 under some circumstances:
The test example he provides:
Yields 'number of audio tracks: 0' on both Windows 10 and 7, as well as NWJS. |
I think there has been a regression of some kind in core chromium. I'll file a bug on Chrome's tracker. NWJS 13.3-win-x64 produces an AudioTrack with the same above example as does v0.14.5-win-x64 0.15.0-rc2-win-x64 demonstrates the issue of having no AudioTrack, as does 0.15.2-win-x64. |
See the following bug I've posted against Chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=624900 |
@thedracle to capture the audio, you'll need to tick "share audio" inside the chooseDesktopMedia |
@ghostoy, Any idea how this should interact with DesktopCaptureMonitor, does just adding 'audio' to the list enable audio sharing? |
For chrome.desktopCapture, you need to add 'audio' to the list and check share audio in the dialog. For nw.Screen.DesktopCaptureMonitor, it should be fixed and you dont need to change your code. I will check the build later tommorrow and give you feedback. |
@thedracle I've tested the original sample code with the live build for commit 0a316ed and it worked on my Windows 7 / 8.1 / 10. |
NWJS 0.15.2-win-64
Windows 10
When obtaining a desktop stream using the DesktopCaptureMedia API described at: http://docs.nwjs.io/en/latest/References/Screen/
It doesn't seem possible to obtain an audio track for the desktop that is being recorded, even when providing aud_constraint, see the function below for an example:
The above function will return a stream, however getAudioTracks() returns an empty array.
How can one go about getting a stream object with the audio track for a desktop stream?
The text was updated successfully, but these errors were encountered: