Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugs in modifiers of nw.MenuItem #5451

Closed
2 tasks done
ghostoy opened this issue Nov 9, 2016 · 0 comments
Closed
2 tasks done

bugs in modifiers of nw.MenuItem #5451

ghostoy opened this issue Nov 9, 2016 · 0 comments
Assignees
@ghostoy
Labels
bug

Comments

@ghostoy
Copy link
Member

ghostoy commented Nov 9, 2016 •
edited
Loading

  1. modifiers should be case insensitive
  2. command and super should be supported same as cmd on macOS
@ghostoy ghostoy self-assigned this Nov 9, 2016
@ghostoy ghostoy mentioned this issue Nov 9, 2016
Closed
@ghostoy ghostoy added the bug label Nov 9, 2016
ghostoy pushed a commit to ghostoy/nw.js that referenced this issue Nov 22, 2016
fixed bugs of modifiers of nw.MenuItem
39d1f27 
* modifiers should be case insensitive
* command and super should be supported same as cmd on macOS

fixed nwjs#5451
@ghostoy ghostoy mentioned this issue Nov 22, 2016
Merged
rogerwang pushed a commit that referenced this issue Nov 23, 2016
@rogerwang
fixed bugs of modifiers of nw.MenuItem
e3159b4 
* modifiers should be case insensitive
* command and super should be supported same as cmd on macOS

fixed #5451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghostoy ghostoy

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ghostoy