Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NW.js 19.2 - Webview freezes on almost any invalid certificate #5564

Closed
janRucka opened this issue Dec 16, 2016 · 12 comments
Closed

NW.js 19.2 - Webview freezes on almost any invalid certificate #5564

janRucka opened this issue Dec 16, 2016 · 12 comments

Comments

@janRucka
Copy link
Contributor

If I create webview in NW.js and navigate it on almost any website with invalid certificate it will freeze. Works fine in Chrome (tested on webview created in extensions).

You can try it here for example:
https://badssl.com/

The same applies to at least NW.js 18. Worked fine in NW.js 14.

@rogerwang
Copy link
Member

rogerwang commented Dec 16, 2016 via email

@janRucka
Copy link
Contributor Author

I didn't see that issue (just looked in open issued) and it seems to be very similar. But I just tried this build:
https://dl.nwjs.io/live-build/12-16-2016/nw19-a83e646-5bca068-287bf0e-c183b55/v0.19.3/nwjs-sdk-v0.19.3-win-ia32.zip
And it still hangs. Should it be fix there?

Adding my test project:
certTest.zip

@Joblytics-io
Copy link

I have the same problem with webview. Even in latest 0.19.3 nightly build and 0.20.0-beta1. Both on windows
@rogerwang We should reopen issue #5544

@rogerwang
Copy link
Member

@bachel I'll fix this issue soon. It should be different with #5544

@rogerwang
Copy link
Member

@janRucka
Copy link
Contributor Author

Really? I tried it again with your link and it's the same. Please try my test project (attached to my previous comment). It will load badssl.com page - this works fine but whenever you click on any link with invalid certificate the whole NW.js will freeze.

@rogerwang
Copy link
Member

I was trying your app and I clicked one of the blocks and it shows a result page, but I was trying win-x64 sdk version. Should be the same with 32bit version.

@janRucka
Copy link
Contributor Author

Result page? Previous version of NW.js (14.x) shown chrome-like page which inform you that you have invalid certificate:
http://cdn.inmotionhosting.com/support/images/stories/website/errors/ssl/chrome-your-connection-is-not-private.png

So it is strange that you can see result page... For me nothing happens, it just freezes no chrome page no result page.

@rogerwang
Copy link
Member

Here is what I was talking about:

1
2

I just realized it may be that our corporate proxy has been injecting certificates trusted in our intranet. Will test again under a different network...

@janRucka
Copy link
Contributor Author

As you said. It can be your proxy. I think you should be warned it is invalid certificate...

@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

@janRucka
Copy link
Contributor Author

Confirmed - it works.
Well done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants