Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NW.js crashes when requiring aws-sdk package and embedded youtube video present on page #5980

Closed
jaredmcateer opened this issue Jun 22, 2017 · 5 comments

Comments

@jaredmcateer
Copy link

Running this using the Ubuntu 16 LTS. I've tested this with nw version 0.23.0, 0.23.1, 0.23.2, 0.23.3, and 0.24.0-beta1sdk.

To reproduce simply install the dependencies using the npm-shrinkwrap.json provided in the sample and run the app. The app will crash while loading the index.html.

I've boiled this down to the smallest test case I could and included a crash dump.

youtube-crash-test.tar.gz

@jaredmcateer
Copy link
Author

I should note that I've also tested this in early versions as well but 0.23.0 is when I've found the problem to manifest.

@keith-pineo
Copy link

I may be experiencing the same issue, except I've been experimenting with Stripe's JS SDK. It adds multiple iframes into the page. Can use either on their own, but the second I try to load both it crashes.

Ubuntu 16.04.2 LTS
NodeJS: v6.11.0 - LTS
NW.js: v0.23.5

AWS_SDK_Stripe_Crash.zip

@jmx
Copy link

jmx commented Jul 1, 2017

we are having this issue in any of our content that loads a video from youtube (our application is a content management system so the reproduction step at this stage is non-trivial). I'll attempt to get a simple repro case during the week but I can confirm that:
a) this issue is more severe and less esoteric than the examples above might imply. We don't use the AWS SDK, for example.
b) issue did not occur in 22.x, but occurs as of 23.x+

@Christywl
Copy link
Contributor

I can reproduce this issue on Linux with nwjs-sdk-v0.23.5.

@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build. It will be released with 0.25.0 soon.

@wanghongjuan wanghongjuan self-assigned this Jan 18, 2018
wanghongjuan added a commit to wanghongjuan/nw.js that referenced this issue Jan 18, 2018
- Add test for issue nwjs#5980
- This case is failed on failed version 0.23.5, pass on fixed version 0.27.4
wanghongjuan added a commit to wanghongjuan/nw.js that referenced this issue Jan 18, 2018
- Add test for issue nwjs#5980
- This case is failed on failed version 0.23.5, pass on fixed version 0.27.4
wanghongjuan added a commit to wanghongjuan/nw.js that referenced this issue Jan 29, 2018
- Add test for issue nwjs#5980
- This case is failed on failed version 0.23.5, pass on fixed version 0.27.4
wanghongjuan added a commit to wanghongjuan/nw.js that referenced this issue Jan 30, 2018
- Add test for issue nwjs#5980
- This case is failed on failed version 0.23.5, pass on fixed version 0.27.4
wanghongjuan added a commit to wanghongjuan/nw.js that referenced this issue Jan 30, 2018
- Add test for issue nwjs#5980
- This case is failed on failed version 0.23.5, pass on fixed version 0.27.4
rogerwang pushed a commit that referenced this issue Feb 5, 2018
- Add test for issue #5980
- This case is failed on failed version 0.23.5, pass on fixed version 0.27.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants