-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maximizing an always on top transparent frameless window causes the bottom to overflow under the taskbar #6204
Comments
Please try this version:
https://dl.nwjs.io/live-build/10-06-2017/nw26-4fae369-edf758a-6de1a29-61e38b8
…On Oct 13, 2017 8:40 AM, "Particle" ***@***.***> wrote:
NWJS Version : SDK 26.0 beta 1
Operating System : Win7 x64
Expected behavior
The bottom of the window should not go under the taskbar when maximized.
Actual behavior
The bottom of the window goes under the taskbar when maximized.
How to reproduce
Basic app template with window frame set to false and transparent set to
true
Maximize app and check the bottom of the window under the windows taskbar
Resulting behavior illustrated:
[image: ss]
<https://user-images.githubusercontent.com/8498057/31525295-cbedd2f4-afae-11e7-8474-fabb49ad3a98.png>
Expected behavior:
[image: ss]
<https://user-images.githubusercontent.com/8498057/31525321-fd8a64f8-afae-11e7-8add-f6cc3c17f06c.png>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#6204>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKGGaiSMMWjtKnnoYDHx6ujeVPnaCiLks5srrFygaJpZM4P30gA>
.
|
@rogerwang The problem is still there and I just noticed that I failed to include another detail so that this issue can be reproduced. I have updated the main issue with the missing detail. The window also needs to be set to So to summarize: Frameless + transparent + always on top causes this issue, even with the latest RC1 you just shared. Removing either one of those three options makes the window behave correctly when maximized. |
@Yonezpt can you sent us your sample app ? |
@jtg-gg Certainly, sorry for the delay. This sample app makes use of the
{
"author": "test",
"description": "test",
"main": "index.html",
"name": "test",
"version": "1.0.0",
"window": {
"id": "test",
"always_on_top": true,
"frame": false,
"transparent": true
}
}
<!DOCTYPE html>
<html>
<head>
</head>
<body style="background: #e2e2e2">
<button onclick="resize();return false;">Click to maximize/restore</button>
<script>
var is_maximized = false;
var gui = require("nw.gui");
var win = gui.Window.get();
win.on("restore", () => is_maximized = false);
win.on("maximize", () => is_maximized = true);
function resize() {
if (is_maximized) {
win.restore();
} else {
win.maximize();
}
}
</script>
</body>
</html> |
set frame to false and always on top to true, refresh it and compile again, or start with a new name of project and copy the code |
@ubaidu15 that is not a solution and it is not something I didn't already know:
that's simply avoiding the problem which is not what I want, otherwise I would not have opened this issue at all if I didn't want a transparent frameless window with the option to stay always on top. |
@Yonezpt I've made a fix, here nwjs/chromium.src#97 |
@jtg-gg thanks. Merged into nw26 master patch. Not merged into nw25 because there is no 0.25 release any more -- 0.26.0 will be released before tomorrow. |
NWJS Version : SDK 26.0 beta 1
Operating System : Win7 x64
Expected behavior
The bottom of the window should not go under the taskbar when maximized.
Actual behavior
The bottom of the window goes under the taskbar when maximized.
How to reproduce
Basic app template with window
frame
set tofalse
,transparent
set totrue
andalways_on_top
set totrue
Maximize app and check the bottom of the window under the windows taskbar
Resulting behavior illustrated:
Expected behavior:
The text was updated successfully, but these errors were encountered: