[win] ship with libexif.dll #4711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libexif is loaded on Windows at start up. When loading failed, it will generate debug.log in the same directory of nw.exe without `--enable-logging`. Ship `libexif.dll` with NW.js will fix this issue. On Mac OS X, it's already shipped with NW.js. On Linux, it loads `libexif.so.12` in system path. Fixed nwjs#4637
|
The dependency of libexif.dll will be removed in CR51. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libexif is loaded on Windows at start up. When loading failed, it
will generate debug.log in the same directory of nw.exe without
--enable-logging. Shiplibexif.dllwith NW.js will fix this issue.On Mac OS X, it's already shipped with NW.js. On Linux, it loads
libexif.so.12in system path.Fixed #4637