implemented win.menu=null to remove menubar
#4743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously in 0.12.x the visibility of menubar on fullscreen/kiosk mode is inconsistent on different platforms. Since 0.13.0, the menubar is always visible on fullscreen / kiok mode. Using `win.menu=null` can remove the menubar manually. This gives developers better control on the menubars. This patch implemented `win.menu=null` to completely remove the menubar on Linux and Windows, and cleared out the menubar on Mac. The patch also updated the docs about menubar visibility on fullscreen mode. Fixed nwjs#4725
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in 0.12.x the visibility of menubar on fullscreen/kiosk
mode is inconsistent on different platforms. Since 0.13.0, the
menubar is always visible on fullscreen / kiok mode. Using
win.menu=nullcan remove the menubar manually. This givesdevelopers better control on the menubars.
This patch implemented
win.menu=nullto completely remove themenubar on Linux and Windows, and cleared out the menubar on Mac.
The patch also updated the docs about menubar visibility on
fullscreen mode.
Fixed #4725