Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to hover #25

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Add documentation to hover #25

merged 1 commit into from
Feb 26, 2018

Conversation

Krzysztof-Cieslak
Copy link
Contributor

Old version:
screenshot from 2018-02-26 01-05-11
screenshot from 2018-02-26 01-05-13
screenshot from 2018-02-26 01-05-16

New version (including clickable link if docs contains URL):
screenshot from 2018-02-26 01-04-35
screenshot from 2018-02-26 01-04-30

screenshot from 2018-02-26 01-04-52

@nwolverson
Copy link
Owner

Nice! I guess the experience from Ionide is that the larger tooltips aren't obtrusive? I've seen that mentioned as an issue in the past but I think at least vscode's hover UI is smooth enough for it to be a non-issue

@Krzysztof-Cieslak
Copy link
Contributor Author

Krzysztof-Cieslak commented Feb 26, 2018

I’ve never had any negative comments about too much information in tooltip. We actually put even more info in there in Ionide - fully qualified name, assembly from each symbol is, resolved types of generic parameters - and people seems to like it.

@nwolverson nwolverson merged commit ba8a20e into nwolverson:master Feb 26, 2018
@Krzysztof-Cieslak Krzysztof-Cieslak deleted the add_documentation_to_hover branch February 27, 2018 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants