Add start of frame notification for lpcip3511 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mcuxsusan , can you help get some reviews for this PR. |
jzipperer-fb
force-pushed
the
jzipperer/sof-notifications
branch
from
05ef2a0 to
29e52b7
Compare
|
@jzipperer-fb Great work! Thanks for this! Could you reference the issue #7 in the PR summary? Hopefully that'll tie things together and the issue will get closed when this merges. |
jzipperer-fb
force-pushed
the
jzipperer/sof-notifications
branch
from
29e52b7 to
a422b77
Compare
|
Done! Anything else needed to get this PR merged? Thanks! |
Let's ask @mcuxcc and @mcuxsusan to take a look 🙏 |
jzipperer-fb
force-pushed
the
jzipperer/sof-notifications
branch
from
a422b77 to
c2fcea8
Compare
This enables the start of frame interrupt. When a start of frame interrupt occurs, a message is created and sent via USB_DeviceNotificationTrigger. Notifications are gated by the define USB_DEVICE_CONFIG_SOF_NOTIFICATIONS. Some upper layers that use this middleware need start of frame notifications for doing isochronous transfers. This fixes the following issue: nxp-mcuxpresso#7 Signed-off-by: James Zipperer <[email protected]>
jzipperer-fb
force-pushed
the
jzipperer/sof-notifications
branch
from
c2fcea8 to
a3883c4
Compare
MarkWangChinese
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#This enables the start of frame interrupt. When a start of frame interrupt occurs, a message is created and sent via USB_DeviceNotificationTrigger.
Notifications are gated by the define USB_DEVICE_CONFIG_SOF_NOTIFICATIONS. Some upper layers that use this middleware need start of frame notifications for doing isochronous transfers.
This fixes the following issue:
#7