Skip to content

Commit

Permalink
stream: sync stream unpipe resume
Browse files Browse the repository at this point in the history
pipe() ondata should not control flow state if cleaned up.

Fixes: nodejs#31190
  • Loading branch information
ronag committed Jan 5, 2020
1 parent 75b30c6 commit ba3fe3f
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/_stream_readable.js
Original file line number Diff line number Diff line change
Expand Up @@ -739,6 +739,7 @@ Readable.prototype.pipe = function(dest, pipeOpts) {
debug('false write response, pause', state.awaitDrainWriters.size);
state.awaitDrainWriters.add(dest);
}
src.pause();
}
if (!ondrain) {
// When the dest drains, it reduces the awaitDrain counter
Expand All @@ -748,7 +749,6 @@ Readable.prototype.pipe = function(dest, pipeOpts) {
ondrain = pipeOnDrain(src, dest);
dest.on('drain', ondrain);
}
src.pause();
}
}

Expand Down
21 changes: 21 additions & 0 deletions test/parallel/test-stream-readable-unpipe-resume.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
'use strict';

const common = require('../common');

const stream = require('stream')

const fs = require('fs');
const readStream = fs.createReadStream('out/Release/node')

const transformStream = new class extends stream.Transform {
_transform() {
readStream.unpipe()
readStream.resume()
}
}

readStream.on('end', common.mustCall());

readStream
.pipe(transformStream)
.resume()

0 comments on commit ba3fe3f

Please sign in to comment.