Prep for support for more WA templates components #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
==========================================
- Coverage 74.44% 74.14% -0.31%
==========================================
Files 98 98
Lines 13130 13166 +36
==========================================
- Hits 9775 9762 -13
- Misses 2665 2714 +49
Partials 690 690 ☔ View full report in Codecov by Sentry. |
norkans7
force-pushed
the
WA-templates-params
branch
from
cd73dc8 to
adc3c7a
Compare
norkans7
commented
Nov 30, 2023
| if len(templating.Params) == 0 { | ||
| component := &Component{Type: "body"} | ||
|
|
||
| for _, v := range templating.Variables { |
There was a problem hiding this comment.
I kept supporting the templating variables so this can be deployed even if the goflow changes are not yet done
norkans7
commented
Nov 30, 2023
handlers/meta/whatsapp/templates.go
Outdated
| @@ -39,3 +44,67 @@ func GetTemplating(msg courier.MsgOut) (*MsgTemplating, error) { | |||
|
|
|||
| return metadata.Templating, nil | |||
| } | |||
|
|
|||
| func GetTemplatePayload(templating MsgTemplating, lang string) *Template { | |||
There was a problem hiding this comment.
I used this method to keep the code DRY between WAC and D3C channels
norkans7
commented
Nov 30, 2023
| component := &Component{Type: "body"} | ||
| for k, v := range templating.Params { | ||
| if k == "body" { | ||
| component := &Component{Type: "body"} |
There was a problem hiding this comment.
Just body to keep the same features but no new components supported for legacy WA channels
norkans7
force-pushed
the
WA-templates-params
branch
from
9d2da92 to
1b66fce
Compare
rowanseymour
requested changes
Jan 15, 2024
| Params map[string][]struct { | ||
| Type string `json:"type"` | ||
| Value string `json:"value"` | ||
| } `json:"params"` |
There was a problem hiding this comment.
let's call this parameters to match the meta side of things
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.