Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log response check error after 200 status #827

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

norkans7
Copy link
Contributor

@norkans7 norkans7 commented Jan 9, 2025

The current behaviour is that the message is failed and we log a report to sentry
This changes to not log to sentry for these issues

@norkans7 norkans7 requested a review from rowanseymour January 9, 2025 21:48
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.85%. Comparing base (c1cc157) to head (ada841b).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
handlers/thinq/handler.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #827      +/-   ##
==========================================
+ Coverage   74.56%   74.85%   +0.28%     
==========================================
  Files         112      112              
  Lines       13274    13274              
==========================================
+ Hits         9898     9936      +38     
+ Misses       2655     2629      -26     
+ Partials      721      709      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour merged commit 60d1e6c into main Jan 14, 2025
7 checks passed
@rowanseymour rowanseymour deleted the EX-response-check branch January 14, 2025 20:07
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants