-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[composer] tabbing through to body doesn't work in firefox #460
Merged
gudsson
merged 4 commits into
main
from
TW-154-composer-bug-tabbing-through-to-body-and-typing-does-not-work-in-firefox
Oct 12, 2022
Merged
[composer] tabbing through to body doesn't work in firefox #460
gudsson
merged 4 commits into
main
from
TW-154-composer-bug-tabbing-through-to-body-and-typing-does-not-work-in-firefox
Oct 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
8762242
to
ba6aaa2
Compare
860ff0a
to
5a3c819
Compare
6c08295
to
553283f
Compare
add back old comment
yifanplanet
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇 Thank you for solving this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
The following issues were identified with the Composer component in Firefox, and seem to be known issues with the Firefox's Selection API implementation with
contenteditable
elements in the Shadow DOM.<input>
elements and prevents typing into the HTML editor unlessdocument.activeElement
is updated by clicking on the background/body.What you did:
focusing
flag that triggers a re-focusing of the HTML editor via asetTimeout
to updateselection
'sanchorNode
/focusNode
, and focus on correct element in the shadow DOM.Screen Captures
Lost cursor and typing lockout on tab-through
Re-focus solution
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.