Split out a nylas-streaming gem
#151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this plan 👍 |
This lays the foundation for a future `nylas-rails` gem while keeping our build process and core dependencies lightweight. We can now have `nylas` be the rest/http client while `nylas-streaming` includes the event machine and yajl functionality so that users who aren't using those don't pull in unnecessary dependencies or run into dependency resolution conflicts. * Inform users that delta streams are now part of nylas-streaming in the README * Add post install message to ask people to read the upgrade guide
zspencer
deleted the
zs-split-out-nylas-rails-and-nylas-streaming-gems
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lays the foundation for a future
nylas-railsgem while keepingour build process and core dependencies lightweight.
We can now have
nylasbe the rest/http client whilenylas-streamingincludes the event machine and yajl functionality so that users who
aren't using those don't pull in unnecessary dependencies or run into
dependency resolution conflicts.
hat tip to @marshall-lee for the inspiration for this.